feat(helpers): allow empty string in fake

Author: ST-DDT

src/modules/helpers/index.ts

@@ -543,7 +543,7 @@ export class HelpersModule {
    */
   fake(str: string): string {
     // if incoming str parameter is not provided, return error message
-    if (typeof str !== 'string' || str.length === 0) {
+    if (typeof str !== 'string') {
       throw new FakerError('string parameter is required!');
     }
 
@@ -617,10 +617,6 @@ export class HelpersModule {
     // We cannot use string.replace here because the result might contain evaluated characters
     const res = str.substring(0, start) + result + str.substring(end + 2);
 
-    if (res === '') {
-      return '';
-    }
-
     // return the response recursively until we are done finding all tags
     return this.fake(res);
   }

test/__snapshots__/helpers.spec.ts.snap

@@ -31,6 +31,8 @@ exports[`helpers > 42 > arrayElements > with array and count 1`] = `
 
 exports[`helpers > 42 > fake > with args 1`] = `"my string: Cky2eiXX/J"`;
 
+exports[`helpers > 42 > fake > with empty string 1`] = `""`;
+
 exports[`helpers > 42 > fake > with plain string 1`] = `"my test string"`;
 
 exports[`helpers > 42 > maybe > with only value 1`] = `"Hello World!"`;
@@ -210,6 +212,8 @@ exports[`helpers > 1211 > arrayElements > with array and count 1`] = `
 
 exports[`helpers > 1211 > fake > with args 1`] = `"my string: wKti5-}$_/"`;
 
+exports[`helpers > 1211 > fake > with empty string 1`] = `""`;
+
 exports[`helpers > 1211 > fake > with plain string 1`] = `"my test string"`;
 
 exports[`helpers > 1211 > maybe > with only value 1`] = `undefined`;
@@ -385,6 +389,8 @@ exports[`helpers > 1337 > arrayElements > with array and count 1`] = `
 
 exports[`helpers > 1337 > fake > with args 1`] = `"my string: 9U/4:SK$>6"`;
 
+exports[`helpers > 1337 > fake > with empty string 1`] = `""`;
+
 exports[`helpers > 1337 > fake > with plain string 1`] = `"my test string"`;
 
 exports[`helpers > 1337 > maybe > with only value 1`] = `"Hello World!"`;

test/helpers.spec.ts

@@ -96,6 +96,7 @@ describe('helpers', () => {
     });
 
     t.describe('fake', (t) => {
+      t.it('with empty string', '');
       t.it('with plain string', 'my test string').it(
         'with args',
         'my string: {{datatype.string}}'
@@ -551,6 +552,11 @@ describe('helpers', () => {
       });
 
       describe('fake()', () => {
+        it('should take an empty string', () => {
+          const actual = faker.helpers.fake('');
+          expect(actual).toBe('');
+        });
+
         it('replaces a token with a random value for a method without parentheses', () => {
           const actual = faker.helpers.fake('{{string.numeric}}');
           expect(actual).toMatch(/^\d$/);