Skip to content

Commit a943353

Browse files
xDivisionByZeroxST-DDTShinigami92
authored
refactor(internet): standardize signatures (#1845)
Co-authored-by: ST-DDT <[email protected]> Co-authored-by: Shinigami <[email protected]>
1 parent c2b21d8 commit a943353

File tree

5 files changed

+1318
-103
lines changed

5 files changed

+1318
-103
lines changed

docs/guide/usage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ function createRandomUser(): User {
148148
const sex = faker.person.sexType();
149149
const firstName = faker.person.firstName(sex);
150150
const lastName = faker.person.lastName();
151-
const email = faker.internet.email(firstName, lastName);
151+
const email = faker.internet.email({ firstName, lastName });
152152

153153
return {
154154
_id: faker.datatype.uuid(),

src/modules/git/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ export class GitModule {
115115
const firstName = this.faker.person.firstName();
116116
const lastName = this.faker.person.lastName();
117117
const fullName = this.faker.person.fullName({ firstName, lastName });
118-
const username = this.faker.internet.userName(firstName, lastName);
118+
const username = this.faker.internet.userName({ firstName, lastName });
119119
let user = this.faker.helpers.arrayElement([fullName, username]);
120-
const email = this.faker.internet.email(firstName, lastName);
120+
const email = this.faker.internet.email({ firstName, lastName });
121121

122122
// Normalize user according to https://github.com/libgit2/libgit2/issues/5342
123123
user = user.replace(/^[\.,:;"\\']|[\<\>\n]|[\.,:;"\\']$/g, '');

0 commit comments

Comments
 (0)