Skip to content

Commit 3e9d1e6

Browse files
committed
fix: removed dead code and added missing types
1 parent 9b3d6b5 commit 3e9d1e6

File tree

1 file changed

+6
-43
lines changed

1 file changed

+6
-43
lines changed

src/system.ts

Lines changed: 6 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export class System {
4747
* @example
4848
* faker.system.fileName() // 'self_enabling_accountability_toys.kpt'
4949
*/
50-
fileName() {
50+
fileName(): string {
5151
let str = this.faker.random.words();
5252
str =
5353
str.toLowerCase().replace(/\W/g, '_') + '.' + this.faker.system.fileExt();
@@ -76,25 +76,7 @@ export class System {
7676
* @example
7777
* faker.system.mimeType() // 'video/vnd.vivo'
7878
*/
79-
mimeType() {
80-
const typeSet = new Set<string>();
81-
const extensionSet = new Set();
82-
const mimeTypes = this.faker.definitions.system.mimeTypes;
83-
84-
Object.keys(mimeTypes).forEach((m) => {
85-
const type = m.split('/')[0];
86-
87-
typeSet.add(type);
88-
89-
if (mimeTypes[m].extensions instanceof Array) {
90-
mimeTypes[m].extensions.forEach((ext) => {
91-
extensionSet.add(ext);
92-
});
93-
}
94-
});
95-
96-
const types = setToArray(typeSet);
97-
const extensions = setToArray(extensionSet);
79+
mimeType(): string {
9880
const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
9981

10082
return this.faker.random.arrayElement(mimeTypeKeys);
@@ -106,7 +88,7 @@ export class System {
10688
* @example
10789
* faker.system.commonFileType() // 'audio'
10890
*/
109-
commonFileType() {
91+
commonFileType(): string {
11092
return this.faker.random.arrayElement(commonFileTypes);
11193
}
11294

@@ -116,7 +98,7 @@ export class System {
11698
* @example
11799
* faker.system.commonFileExt() // 'gif'
118100
*/
119-
commonFileExt() {
101+
commonFileExt(): string {
120102
return this.faker.system.fileExt(
121103
this.faker.random.arrayElement(commonMimeTypes)
122104
);
@@ -128,7 +110,7 @@ export class System {
128110
* @example
129111
* faker.system.fileType() // 'message'
130112
*/
131-
fileType() {
113+
fileType(): string {
132114
const typeSet = new Set<string>();
133115
const extensionSet = new Set();
134116
const mimeTypes = this.faker.definitions.system.mimeTypes;
@@ -146,8 +128,6 @@ export class System {
146128
});
147129

148130
const types = setToArray(typeSet);
149-
const extensions = setToArray(extensionSet);
150-
const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
151131
return this.faker.random.arrayElement(types);
152132
}
153133

@@ -161,25 +141,8 @@ export class System {
161141
* faker.system.fileExt('application/json') // 'json'
162142
*/
163143
fileExt(mimeType?: string): string {
164-
const typeSet = new Set<string>();
165144
const extensionSet = new Set<string>();
166-
const mimeTypes = this.faker.definitions.system.mimeTypes;
167-
168-
Object.keys(mimeTypes).forEach((m) => {
169-
const type = m.split('/')[0];
170-
171-
typeSet.add(type);
172-
173-
if (mimeTypes[m].extensions instanceof Array) {
174-
mimeTypes[m].extensions.forEach((ext) => {
175-
extensionSet.add(ext);
176-
});
177-
}
178-
});
179-
180-
const types = setToArray(typeSet);
181145
const extensions = setToArray(extensionSet);
182-
const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
183146

184147
if (mimeType) {
185148
const mimes = this.faker.definitions.system.mimeTypes;
@@ -206,7 +169,7 @@ export class System {
206169
* @example
207170
* faker.system.filePath() // '/usr/local/src/money.rmp.dotx'
208171
*/
209-
filePath() {
172+
filePath(): string {
210173
return this.faker.fake(
211174
'{{system.directoryPath}}/{{system.fileName}}.{{system.fileExt}}'
212175
);

0 commit comments

Comments
 (0)