infra(deps): add eslint unicorn (#2418)

Co-authored-by: ST-DDT <[email protected]>

Author: Shinigami92

.eslintrc.js

@@ -19,6 +19,7 @@ module.exports = defineConfig({
     'plugin:@typescript-eslint/recommended-type-checked',
     'plugin:prettier/recommended',
     'plugin:jsdoc/recommended-typescript-error',
+    'plugin:unicorn/recommended',
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
@@ -37,6 +38,64 @@ module.exports = defineConfig({
 
     'deprecation/deprecation': 'error',
 
+    'unicorn/no-nested-ternary': 'off', // incompatible with prettier
+    'unicorn/no-null': 'off', // incompatible with TypeScript
+    'unicorn/number-literal-case': 'off', // incompatible with prettier
+
+    // TODO @Shinigami92 2023-09-23: prefer-at should be turned on when we drop support for Node 14.
+    'unicorn/prefer-at': 'off',
+    // TODO @Shinigami92 2023-09-23: prefer-string-replace-all should be turned on when we drop support for Node 14.
+    'unicorn/prefer-string-replace-all': 'off',
+
+    // TODO @Shinigami92 2023-09-23: The following rules currently conflict with our code.
+    // Each rule should be checked whether it should be enabled/configured and the problems fixed, or stay disabled permanently.
+    'unicorn/better-regex': 'off',
+    'unicorn/catch-error-name': 'off',
+    'unicorn/consistent-destructuring': 'off',
+    'unicorn/consistent-function-scoping': 'off',
+    'unicorn/escape-case': 'off',
+    'unicorn/explicit-length-check': 'off',
+    'unicorn/filename-case': 'off',
+    'unicorn/import-style': 'off',
+    'unicorn/no-array-callback-reference': 'off',
+    'unicorn/no-array-for-each': 'off',
+    'unicorn/no-array-push-push': 'off',
+    'unicorn/no-array-reduce': 'off',
+    'unicorn/no-await-expression-member': 'off',
+    'unicorn/no-console-spaces': 'off',
+    'unicorn/no-for-loop': 'off',
+    'unicorn/no-hex-escape': 'off',
+    'unicorn/no-instanceof-array': 'off',
+    'unicorn/no-negated-condition': 'off',
+    'unicorn/no-new-array': 'off',
+    'unicorn/no-object-as-default-parameter': 'off',
+    'unicorn/no-process-exit': 'off',
+    'unicorn/no-useless-switch-case': 'off',
+    'unicorn/no-zero-fractions': 'off',
+    'unicorn/numeric-separators-style': 'off',
+    'unicorn/prefer-array-flat-map': 'off',
+    'unicorn/prefer-array-some': 'off',
+    'unicorn/prefer-code-point': 'off',
+    'unicorn/prefer-date-now': 'off',
+    'unicorn/prefer-export-from': 'off',
+    'unicorn/prefer-includes': 'off',
+    'unicorn/prefer-module': 'off',
+    'unicorn/prefer-native-coercion-functions': 'off',
+    'unicorn/prefer-negative-index': 'off',
+    'unicorn/prefer-node-protocol': 'off',
+    'unicorn/prefer-number-properties': 'off',
+    'unicorn/prefer-object-from-entries': 'off',
+    'unicorn/prefer-optional-catch-binding': 'off',
+    'unicorn/prefer-spread': 'off',
+    'unicorn/prefer-string-slice': 'off',
+    'unicorn/prefer-string-starts-ends-with': 'off',
+    'unicorn/prefer-ternary': 'off',
+    'unicorn/prefer-top-level-await': 'off',
+    'unicorn/prevent-abbreviations': 'off',
+    'unicorn/require-array-join-separator': 'off',
+    'unicorn/switch-case-braces': 'off',
+    'unicorn/text-encoding-identifier-case': 'off',
+
     '@typescript-eslint/array-type': [
       'error',
       { default: 'array-simple', readonly: 'generic' },

package.json

@@ -109,6 +109,7 @@
     "eslint-plugin-deprecation": "~2.0.0",
     "eslint-plugin-jsdoc": "~46.8.2",
     "eslint-plugin-prettier": "~5.0.0",
+    "eslint-plugin-unicorn": "~48.0.1",
     "eslint-plugin-vitest": "~0.3.1",
     "glob": "~10.3.10",
     "npm-run-all": "~4.1.5",