Skip to content

Commit 0d4cba6

Browse files
matthewmayermatthewmayer
authored
refactor(person)!: flatten jobs definitions (#2505)
1 parent 682a427 commit 0d4cba6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+1172
-1124
lines changed

‎docs/guide/upgrading_v9/2505.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
### Jobs definitions reorganized
2+
3+
The locale definitions used by `faker.person.jobTitle()`, `faker.person.jobDescriptor()`, `faker.person.jobArea()` and `faker.person.jobType()` have been reorganized and are no longer nested under `definitions.person.title`. If you are using the public methods, no changes are required. You only need to change your code if you are accessing the raw definitions e.g. in `faker.helpers.fake()`.
4+
5+
| Before | After |
6+
| ------------------------- | ----------------------- |
7+
| `person.title.descriptor` | `person.job_descriptor` |
8+
| `person.title.level` | `person.job_area` |
9+
| `person.title.job` | `person.job_type` |

‎src/definitions/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export type { LocationDefinition } from './location';
1717
export type { LoremDefinition } from './lorem';
1818
export type { MetadataDefinition } from './metadata';
1919
export type { MusicDefinition } from './music';
20-
export type { PersonDefinition, PersonTitleDefinition } from './person';
20+
export type { PersonDefinition } from './person';
2121
export type { PhoneNumberDefinition } from './phone_number';
2222
export type { ScienceDefinition } from './science';
2323
export type { SystemDefinition, SystemMimeTypeEntryDefinition } from './system';

‎src/definitions/person.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,11 @@ export type PersonDefinition = LocaleEntry<{
3939

4040
bio_pattern: string[];
4141

42-
title: PersonTitleDefinition;
42+
job_descriptor: string[];
43+
job_area: string[];
44+
job_type: string[];
4345

4446
job_title_pattern: string[];
4547

4648
western_zodiac_sign: string[];
4749
}>;
48-
49-
/**
50-
* The possible definitions related to people's titles.
51-
*/
52-
export type PersonTitleDefinition = LocaleEntry<{
53-
descriptor: string[];
54-
job: string[];
55-
level: string[];
56-
}>;

‎src/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,7 @@ export type {
4949
MusicDefinition as MusicDefinitions,
5050
/** @deprecated Use PersonDefinitions instead */
5151
PersonDefinition as NameDefinitions,
52-
/** @deprecated Use PersonTitleDefinitions instead */
53-
PersonTitleDefinition as NameTitleDefinitions,
5452
PersonDefinition,
55-
PersonTitleDefinition,
5653
PhoneNumberDefinition,
5754
/** @deprecated Use PhoneNumberDefinition instead */
5855
PhoneNumberDefinition as PhoneNumberDefinitions,

‎src/locales/ar/person/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ import type { PersonDefinition } from '../../..';
66
import female_first_name from './female_first_name';
77
import female_prefix from './female_prefix';
88
import first_name from './first_name';
9+
import job_type from './job_type';
910
import last_name from './last_name';
1011
import last_name_pattern from './last_name_pattern';
1112
import male_first_name from './male_first_name';
1213
import male_prefix from './male_prefix';
1314
import name_ from './name';
1415
import prefix from './prefix';
1516
import suffix from './suffix';
16-
import title from './title';
1717

1818
const person: PersonDefinition = {
1919
female_first_name,
2020
female_prefix,
2121
first_name,
22+
job_type,
2223
last_name,
2324
last_name_pattern,
2425
male_first_name,
2526
male_prefix,
2627
name: name_,
2728
prefix,
2829
suffix,
29-
title,
3030
};
3131

3232
export default person;

‎src/locales/ar/person/job_type.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
export default [
2+
'مشرف',
3+
'تنفيذي',
4+
'مدير',
5+
'مهندس',
6+
'متخصص',
7+
'رئيس مؤسسة',
8+
'منسق',
9+
'إداري',
10+
'مخطط',
11+
'محلل',
12+
'مصمم',
13+
'تقني',
14+
'مبرمج',
15+
'منتج',
16+
'مستشار',
17+
'مساعد',
18+
'وكيل',
19+
'متدرب',
20+
];

‎src/locales/ar/person/title.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎src/locales/el/person/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,29 @@ import type { PersonDefinition } from '../../..';
66
import female_first_name from './female_first_name';
77
import female_prefix from './female_prefix';
88
import first_name from './first_name';
9+
import job_area from './job_area';
10+
import job_descriptor from './job_descriptor';
11+
import job_type from './job_type';
912
import last_name from './last_name';
1013
import last_name_pattern from './last_name_pattern';
1114
import male_first_name from './male_first_name';
1215
import male_prefix from './male_prefix';
1316
import name_ from './name';
1417
import prefix from './prefix';
15-
import title from './title';
1618

1719
const person: PersonDefinition = {
1820
female_first_name,
1921
female_prefix,
2022
first_name,
23+
job_area,
24+
job_descriptor,
25+
job_type,
2126
last_name,
2227
last_name_pattern,
2328
male_first_name,
2429
male_prefix,
2530
name: name_,
2631
prefix,
27-
title,
2832
};
2933

3034
export default person;

‎src/locales/el/person/job_area.ts

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
export default [
2+
'Λύσεις',
3+
'Πρόγραμμα',
4+
'Μάρκα',
5+
'Ασφάλεια',
6+
'Έρευνα',
7+
'Μάρκετινγκ',
8+
'Οδηγιών',
9+
'Εφαρμογή',
10+
'Ενσωμάτωση',
11+
'Λειτουργικότητα',
12+
'Τακτική',
13+
'Ταυτότητα',
14+
'Αγορές',
15+
'Όμιλος',
16+
'Εφαρμογές',
17+
'Βελτιστοποίηση',
18+
'Δραστηριότητες',
19+
'Υποδομή',
20+
'Intranet',
21+
'Επικοινωνίες',
22+
'Web',
23+
'Branding',
24+
'Ποιότητα',
25+
'Διασφάλιση',
26+
'Κινητικότητα',
27+
'Λογαριασμοί',
28+
'Δεδομένα',
29+
'Δημιουργική',
30+
'Διαμόρφωση',
31+
'Μετρήσεις',
32+
];

‎src/locales/el/person/job_descriptor.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
export default [
2+
'Senior',
3+
'Εταιρείες',
4+
'Πελάτης',
5+
'Επενδυτής',
6+
'Εσωτερικό',
7+
'Κύριος',
8+
];

‎src/locales/el/person/job_type.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
export default [
2+
'Επόπτης',
3+
'Συνεργάτης',
4+
'Σύμβουλος',
5+
'Διευθυντής',
6+
'Μηχανικός',
7+
'Ειδικός',
8+
'Συντονιστή',
9+
'Διαχειριστής',
10+
'Αναλυτής',
11+
'Designer',
12+
'Τεχνικός',
13+
'Προγραμματιστής',
14+
'Παραγωγός',
15+
'Βοηθός',
16+
'Συντονιστής',
17+
'Εκπρόσωπος',
18+
'Αντιπρόσωπος',
19+
];

‎src/locales/el/person/title.ts

Lines changed: 0 additions & 61 deletions
This file was deleted.

‎src/locales/en/person/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ import female_middle_name from './female_middle_name';
1111
import female_prefix from './female_prefix';
1212
import first_name from './first_name';
1313
import gender from './gender';
14+
import job_area from './job_area';
15+
import job_descriptor from './job_descriptor';
1416
import job_title_pattern from './job_title_pattern';
17+
import job_type from './job_type';
1518
import last_name from './last_name';
1619
import last_name_pattern from './last_name_pattern';
1720
import male_first_name from './male_first_name';
@@ -22,7 +25,6 @@ import name_ from './name';
2225
import prefix from './prefix';
2326
import sex from './sex';
2427
import suffix from './suffix';
25-
import title from './title';
2628
import western_zodiac_sign from './western_zodiac_sign';
2729

2830
const person: PersonDefinition = {
@@ -34,7 +36,10 @@ const person: PersonDefinition = {
3436
female_prefix,
3537
first_name,
3638
gender,
39+
job_area,
40+
job_descriptor,
3741
job_title_pattern,
42+
job_type,
3843
last_name,
3944
last_name_pattern,
4045
male_first_name,
@@ -45,7 +50,6 @@ const person: PersonDefinition = {
4550
prefix,
4651
sex,
4752
suffix,
48-
title,
4953
western_zodiac_sign,
5054
};
5155

‎src/locales/en/person/job_area.ts

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
export default [
2+
'Solutions',
3+
'Program',
4+
'Brand',
5+
'Security',
6+
'Research',
7+
'Marketing',
8+
'Directives',
9+
'Implementation',
10+
'Integration',
11+
'Functionality',
12+
'Response',
13+
'Paradigm',
14+
'Tactics',
15+
'Identity',
16+
'Markets',
17+
'Group',
18+
'Division',
19+
'Applications',
20+
'Optimization',
21+
'Operations',
22+
'Infrastructure',
23+
'Intranet',
24+
'Communications',
25+
'Web',
26+
'Branding',
27+
'Quality',
28+
'Assurance',
29+
'Mobility',
30+
'Accounts',
31+
'Data',
32+
'Creative',
33+
'Configuration',
34+
'Accountability',
35+
'Interactions',
36+
'Factors',
37+
'Usability',
38+
'Metrics',
39+
];

‎src/locales/en/person/job_descriptor.ts

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
export default [
2+
'Lead',
3+
'Senior',
4+
'Direct',
5+
'Corporate',
6+
'Dynamic',
7+
'Future',
8+
'Product',
9+
'National',
10+
'Regional',
11+
'District',
12+
'Central',
13+
'Global',
14+
'Customer',
15+
'Investor',
16+
'International',
17+
'Legacy',
18+
'Forward',
19+
'Internal',
20+
'Human',
21+
'Chief',
22+
'Principal',
23+
];

0 commit comments

Comments
 (0)