Skip to content

Commit ea2c829

Browse files
committed
Backport - Fix misidentified WebView token as device model - found in #681 (cherry picked from commit b51ae9e)
1 parent 3b896d5 commit ea2c829

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

src/ua-parser.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,9 +270,9 @@
270270
/fxios\/([-\w\.]+)/i // Firefox for iOS
271271
], [VERSION, [NAME, FIREFOX]], [
272272
/\bqihu|(qi?ho?o?|360)browser/i // 360
273-
], [[NAME, '360' + SUFFIX_BROWSER]], [
273+
], [[NAME, '360 ' + BROWSER]], [
274274
/(oculus|samsung|sailfish|huawei|vivo)browser\/([\w\.]+)/i
275-
], [[NAME, /(.+)/, '$1' + SUFFIX_BROWSER], VERSION], [ // Oculus/Samsung/Sailfish/HuaweiBrowser/VivoBrowser
275+
], [[NAME, /(.+)/, '$1 ' + BROWSER], VERSION], [ // Oculus/Samsung/Sailfish/HuaweiBrowser/VivoBrowser
276276
/(comodo_dragon)\/([\w\.]+)/i // Comodo Dragon
277277
], [[NAME, /_/g, ' '], VERSION], [
278278
/(electron)\/([\w\.]+) safari/i, // Electron-based App
@@ -419,7 +419,7 @@
419419
/\b; (\w+) build\/hm\1/i, // Xiaomi Hongmi 'numeric' models
420420
/\b(hm[-_ ]?note?[_ ]?(?:\d\w)?) bui/i, // Xiaomi Hongmi
421421
/\b(redmi[\-_ ]?(?:note|k)?[\w_ ]+)(?: bui|\))/i, // Xiaomi Redmi
422-
/oid[^\)]+; (m?[12][0-389][01]\w{3,6}[c-y])( bui|\))/i, // Xiaomi Redmi 'numeric' models
422+
/oid[^\)]+; (m?[12][0-389][01]\w{3,6}[c-y])( bui|; wv|\))/i, // Xiaomi Redmi 'numeric' models
423423
/\b(mi[-_ ]?(?:a\d|one|one[_ ]plus|note lte|max|cc)?[_ ]?(?:\d?\w?)[_ ]?(?:plus|se|lite)?)(?: bui|\))/i // Xiaomi Mi
424424
], [[MODEL, /_/g, ' '], [VENDOR, XIAOMI], [TYPE, MOBILE]], [
425425
/oid[^\)]+; (2\d{4}(283|rpbf)[cgl])( bui|\))/i, // Redmi Pad
@@ -682,7 +682,7 @@
682682
// MIXED (GENERIC)
683683
///////////////////
684684

685-
/droid .+?; ([^;]+?)(?: bui|\) applew).+? mobile safari/i // Android Phones from Unidentified Vendors
685+
/droid .+?; ([^;]+?)(?: bui|; wv\)|\) applew).+? mobile safari/i // Android Phones from Unidentified Vendors
686686
], [MODEL, [TYPE, MOBILE]], [
687687
/droid .+?; ([^;]+?)(?: bui|\) applew).+?(?! mobile) safari/i // Android Tablets from Unidentified Vendors
688688
], [MODEL, [TYPE, TABLET]], [

test/device-test.json

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2807,6 +2807,24 @@
28072807
"type": "mobile"
28082808
}
28092809
},
2810+
{
2811+
"desc": "XiaoMi Redmi Note 12 Turbo",
2812+
"ua": "Mozilla/5.0 (Linux; Android 13; 23049RAD8C; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/87.0.4280.141 Mobile Safari/537.36 VivoBrowser/16.7.1.1",
2813+
"expect": {
2814+
"vendor": "Xiaomi",
2815+
"model": "23049RAD8C",
2816+
"type": "mobile"
2817+
}
2818+
},
2819+
{
2820+
"desc": "ZTE Blade A6",
2821+
"ua": "Mozilla/5.0 (Linux; Android 7.1.1; ZTE BLADE A0620 Build/NMF26F; ru-ru) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.136 Mobile Safari/537.36 Puffin/9.2.0.50586AP",
2822+
"expect": {
2823+
"vendor": "ZTE",
2824+
"model": "BLADE A0620",
2825+
"type": "mobile"
2826+
}
2827+
},
28102828
{
28112829
"desc": "PlayStation 4",
28122830
"ua": "Mozilla/5.0 (PlayStation 4 3.00) AppleWebKit/537.73 (KHTML, like Gecko)",

0 commit comments

Comments
 (0)