You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Fizz] Don't double replay elements when it's the postpone point (#27440)
The `resumeElement` function wasn't actually doing the correct thing
because it was resuming the element itself but what the child slot means
is that we're supposed to resume in the direct child of the element.
This is difficult to check for since it's all the possible branches that
the element can render into, so instead we just check this in
renderNode. It means the hottest path always checks the task which is
unfortunate.
And also, resuming using the correct nextSegmentId.
Fixes two bugs surfaced by this test.
---------
Co-authored-by: Josh Story <[email protected]>
DiffTrain build for commit a6ed60a.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -23997,7 +23997,7 @@ function createFiberRoot(
23997
23997
return root;
23998
23998
}
23999
23999
24000
-
var ReactVersion = "18.3.0-canary-c7ba8c098-20230929";
24000
+
var ReactVersion = "18.3.0-canary-a6ed60a8e-20230929";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -8623,7 +8623,7 @@ var devToolsConfig$jscomp$inline_1030 = {
8623
8623
throwError("TestRenderer does not support findFiberByHostInstance()");
8624
8624
},
8625
8625
bundleType: 0,
8626
-
version: "18.3.0-canary-c7ba8c098-20230929",
8626
+
version: "18.3.0-canary-a6ed60a8e-20230929",
8627
8627
rendererPackageName: "react-test-renderer"
8628
8628
};
8629
8629
varinternals$jscomp$inline_1229={
@@ -8654,7 +8654,7 @@ var internals$jscomp$inline_1229 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9049,7 +9049,7 @@ var devToolsConfig$jscomp$inline_1072 = {
9049
9049
throwError("TestRenderer does not support findFiberByHostInstance()");
9050
9050
},
9051
9051
bundleType: 0,
9052
-
version: "18.3.0-canary-c7ba8c098-20230929",
9052
+
version: "18.3.0-canary-a6ed60a8e-20230929",
9053
9053
rendererPackageName: "react-test-renderer"
9054
9054
};
9055
9055
varinternals$jscomp$inline_1270={
@@ -9080,7 +9080,7 @@ var internals$jscomp$inline_1270 = {
0 commit comments