Skip to content

Commit 191c16a

Browse files
committed
[Fizz] Fix children rendering in custom elements with enableCustomElementPropertySupport (#27511)
The `enableCustomElementPropertySupport` flag changes React's handling of custom elements in a way that is more useful that just treating every prop as an attribute. However when server rendering we have no choice but to serialize props as attributes. When this flag is on and React supports more prop types on the client like functions and objects the server implementation needs to be a bit more naunced in how it renders these components. With this flag on `false`, function, and object props are omitted entirely and `true` is normalized to `""`. There was a bug however in the implementation which caused children more complex than a single string to be omitted because it matched the object type filter. This change reorganizes the code a bit to put these filters in the default prop handline case, leaving children, style, and innerHTML to be handled via normal logic. fixes: #27286 DiffTrain build for commit bb77852.
1 parent d1f9770 commit 191c16a

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24770,7 +24770,7 @@ function createFiberRoot(
2477024770
return root;
2477124771
}
2477224772

24773-
var ReactVersion = "18.3.0-canary-ea8a8619c-20231012";
24773+
var ReactVersion = "18.3.0-canary-bb778528d-20231012";
2477424774

2477524775
// Might add PROFILE later.
2477624776

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8968,7 +8968,7 @@ var devToolsConfig$jscomp$inline_1008 = {
89688968
throw Error("TestRenderer does not support findFiberByHostInstance()");
89698969
},
89708970
bundleType: 0,
8971-
version: "18.3.0-canary-ea8a8619c-20231012",
8971+
version: "18.3.0-canary-bb778528d-20231012",
89728972
rendererPackageName: "react-test-renderer"
89738973
};
89748974
var internals$jscomp$inline_1201 = {
@@ -8999,7 +8999,7 @@ var internals$jscomp$inline_1201 = {
89998999
scheduleRoot: null,
90009000
setRefreshHandler: null,
90019001
getCurrentFiber: null,
9002-
reconcilerVersion: "18.3.0-canary-ea8a8619c-20231012"
9002+
reconcilerVersion: "18.3.0-canary-bb778528d-20231012"
90039003
};
90049004
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90059005
var hook$jscomp$inline_1202 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9394,7 +9394,7 @@ var devToolsConfig$jscomp$inline_1050 = {
93949394
throw Error("TestRenderer does not support findFiberByHostInstance()");
93959395
},
93969396
bundleType: 0,
9397-
version: "18.3.0-canary-ea8a8619c-20231012",
9397+
version: "18.3.0-canary-bb778528d-20231012",
93989398
rendererPackageName: "react-test-renderer"
93999399
};
94009400
var internals$jscomp$inline_1242 = {
@@ -9425,7 +9425,7 @@ var internals$jscomp$inline_1242 = {
94259425
scheduleRoot: null,
94269426
setRefreshHandler: null,
94279427
getCurrentFiber: null,
9428-
reconcilerVersion: "18.3.0-canary-ea8a8619c-20231012"
9428+
reconcilerVersion: "18.3.0-canary-bb778528d-20231012"
94299429
};
94309430
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
94319431
var hook$jscomp$inline_1243 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-ea8a8619c-20231012";
30+
var ReactVersion = "18.3.0-canary-bb778528d-20231012";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
580580
exports.useTransition = function () {
581581
return ReactCurrentDispatcher.current.useTransition();
582582
};
583-
exports.version = "18.3.0-canary-ea8a8619c-20231012";
583+
exports.version = "18.3.0-canary-bb778528d-20231012";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
583583
exports.useTransition = function () {
584584
return ReactCurrentDispatcher.current.useTransition();
585585
};
586-
exports.version = "18.3.0-canary-ea8a8619c-20231012";
586+
exports.version = "18.3.0-canary-bb778528d-20231012";
587587

588588
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
589589
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ea8a8619ce51a0f8f0a78f87485e4e2a6f9d8c27
1+
bb778528d1ca22b44dad832f0258aaa4c0e6d4a4

0 commit comments

Comments
 (0)