Invalidate layout when node is removed from tree

Emil Sjolander · facebook-github-bot · commit e85477552784 · 2017-03-17T09:20:51.000-07:00
Reviewed By: astreet

Differential Revision: D4716022

fbshipit-source-id: 399cc64a4b3f5fd3fc469ea37bdd31abe474dc6c
diff --git a/ReactCommon/yoga/yoga/Yoga.c b/ReactCommon/yoga/yoga/Yoga.c
@@ -423,6 +423,7 @@ void YGNodeInsertChild(const YGNodeRef node, const YGNodeRef child, const uint32
 
 void YGNodeRemoveChild(const YGNodeRef node, const YGNodeRef child) {
   if (YGNodeListDelete(node->children, child) != NULL) {
+    child->layout = gYGNodeDefaults.layout; // layout is no longer valid
     child->parent = NULL;
     YGNodeMarkDirtyInternal(node);
   }

Original file line number	Diff line number	Diff line change
`@@ -423,6 +423,7 @@ void YGNodeInsertChild(const YGNodeRef node, const YGNodeRef child, const uint32`
`423`	`423`
`424`	`424`	`void YGNodeRemoveChild(const YGNodeRef node, const YGNodeRef child) {`
`425`	`425`	`if (YGNodeListDelete(node->children, child) != NULL) {`
	`426`	`+ child->layout = gYGNodeDefaults.layout; // layout is no longer valid`
`426`	`427`	`child->parent = NULL;`
`427`	`428`	`YGNodeMarkDirtyInternal(node);`
`428`	`429`	`}`