Check feature flags for a11yOrder iff prop exists (#50967)

joevilches · facebook-github-bot · commit e486fda106e7 · 2025-04-28T14:39:31.000-07:00
Summary: Pull Request resolved: #50967 In some cases we may want to check this only if the prop exists Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D73793783 fbshipit-source-id: b498f82414edf63d8644b90bb3932298eb37b43c
diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
@@ -391,8 +391,8 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
     }
   }
 
-  if (ReactNativeFeatureFlags::enableAccessibilityOrder() &&
-      oldViewProps.accessibilityOrder != newViewProps.accessibilityOrder) {
+  if (oldViewProps.accessibilityOrder != newViewProps.accessibilityOrder &&
+      ReactNativeFeatureFlags::enableAccessibilityOrder()) {
     _accessibleElementsNativeIds = [NSMutableArray new];
     for (const std::string &childId : newViewProps.accessibilityOrder) {
       [_accessibleElementsNativeIds addObject:RCTNSStringFromString(childId)];

Original file line number	Diff line number	Diff line change
`@@ -391,8 +391,8 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &`
`391`	`391`	`}`
`392`	`392`	`}`
`393`	`393`
`394`		`- if (ReactNativeFeatureFlags::enableAccessibilityOrder() &&`
`395`		`- oldViewProps.accessibilityOrder != newViewProps.accessibilityOrder) {`
	`394`	`+ if (oldViewProps.accessibilityOrder != newViewProps.accessibilityOrder &&`
	`395`	`+ ReactNativeFeatureFlags::enableAccessibilityOrder()) {`
`396`	`396`	`_accessibleElementsNativeIds = [NSMutableArray new];`
`397`	`397`	`for (const std::string &childId : newViewProps.accessibilityOrder) {`
`398`	`398`	`[_accessibleElementsNativeIds addObject:RCTNSStringFromString(childId)];`