Skip to content

Commit a4300da

Browse files
ayc1facebook-github-bot
authored andcommitted
Move idle detection classes to its own directory
Reviewed By: AaaChiuuu Differential Revision: D4738755 fbshipit-source-id: df3b215991a45932283f6ba9d800aeff1c31d2e6
1 parent 3954400 commit a4300da

10 files changed

+30
-5
lines changed

ReactAndroid/src/androidTest/java/com/facebook/react/testing/BUCK

+5-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ include_defs("//ReactAndroid/DEFS")
22

33
android_library(
44
name = "testing",
5-
srcs = glob(["**/*.java"]),
5+
srcs = glob(
6+
["**/*.java"],
7+
excludes = ["idledetection/**/*.java"],
8+
),
69
visibility = [
710
"PUBLIC",
811
],
@@ -25,5 +28,6 @@ android_library(
2528
react_native_target("java/com/facebook/react/modules/debug:interfaces"),
2629
react_native_target("java/com/facebook/react/shell:shell"),
2730
react_native_target("java/com/facebook/react/uimanager:uimanager"),
31+
react_native_integration_tests_target("java/com/facebook/react/testing/idledetection:idledetection"),
2832
],
2933
)

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactAppInstrumentationTestCase.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import com.facebook.infer.annotation.Assertions;
2222
import com.facebook.react.bridge.ReactContext;
23+
import com.facebook.react.testing.idledetection.IdleWaiter;
2324

2425
/**
2526
* Base class for instrumentation tests that runs React based react application in UI mode
@@ -123,7 +124,6 @@ public void run() {
123124
}
124125
};
125126

126-
127127
getActivity().runOnUiThread(getScreenshotRunnable);
128128
try {
129129
if (!latch.await(5000, TimeUnit.MILLISECONDS)) {

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactAppTestActivity.java

+2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
import com.facebook.react.common.LifecycleState;
2929
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
3030
import com.facebook.react.shell.MainReactPackage;
31+
import com.facebook.react.testing.idledetection.ReactBridgeIdleSignaler;
32+
import com.facebook.react.testing.idledetection.ReactIdleDetectionUtil;
3133
import com.facebook.react.uimanager.UIImplementationProvider;
3234

3335
public class ReactAppTestActivity extends FragmentActivity implements

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactIntegrationTestCase.java

+2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
import com.facebook.react.common.futures.SimpleSettableFuture;
3333
import com.facebook.react.devsupport.interfaces.DevSupportManager;
3434
import com.facebook.react.modules.core.Timing;
35+
import com.facebook.react.testing.idledetection.ReactBridgeIdleSignaler;
36+
import com.facebook.react.testing.idledetection.ReactIdleDetectionUtil;
3537
import com.facebook.soloader.SoLoader;
3638

3739
import static org.mockito.Mockito.mock;

ReactAndroid/src/androidTest/java/com/facebook/react/testing/SingleTouchGestureGenerator.java

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import android.view.View;
1414
import android.view.ViewConfiguration;
1515

16+
import com.facebook.react.testing.idledetection.IdleWaiter;
17+
1618
/**
1719
* Provides methods for generating touch events and dispatching them directly to a given view.
1820
* Events scenarios are based on {@link android.test.TouchUtils} but they get gets dispatched
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
include_defs("//ReactAndroid/DEFS")
2+
3+
android_library(
4+
name = "idledetection",
5+
srcs = glob(["**/*.java"]),
6+
visibility = [
7+
"PUBLIC",
8+
],
9+
deps = [
10+
react_native_dep("third-party/java/testing-support-lib:runner"),
11+
react_native_target("java/com/facebook/react/bridge:bridge"),
12+
react_native_target("java/com/facebook/react/modules/core:core"),
13+
],
14+
)

ReactAndroid/src/androidTest/java/com/facebook/react/testing/IdleWaiter.java renamed to ReactAndroid/src/androidTest/java/com/facebook/react/testing/idledetection/IdleWaiter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* of patent rights can be found in the PATENTS file in the same directory.
77
*/
88

9-
package com.facebook.react.testing;
9+
package com.facebook.react.testing.idledetection;
1010

1111
/**
1212
* Interface for something that knows how to wait for bridge and UI idle.

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactBridgeIdleSignaler.java renamed to ReactAndroid/src/androidTest/java/com/facebook/react/testing/idledetection/ReactBridgeIdleSignaler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* of patent rights can be found in the PATENTS file in the same directory.
77
*/
88

9-
package com.facebook.react.testing;
9+
package com.facebook.react.testing.idledetection;
1010

1111
import java.util.concurrent.Semaphore;
1212
import java.util.concurrent.TimeUnit;

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactIdleDetectionUtil.java renamed to ReactAndroid/src/androidTest/java/com/facebook/react/testing/idledetection/ReactIdleDetectionUtil.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* of patent rights can be found in the PATENTS file in the same directory.
77
*/
88

9-
package com.facebook.react.testing;
9+
package com.facebook.react.testing.idledetection;
1010

1111
import java.util.concurrent.CountDownLatch;
1212
import java.util.concurrent.TimeUnit;

ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ deps = [
55
react_native_dep("third-party/java/jsr-305:jsr-305"),
66
react_native_dep("third-party/java/junit:junit"),
77
react_native_integration_tests_target("java/com/facebook/react/testing:testing"),
8+
react_native_integration_tests_target("java/com/facebook/react/testing/idledetection:idledetection"),
89
react_native_target("java/com/facebook/react:react"),
910
react_native_target("java/com/facebook/react/bridge:bridge"),
1011
react_native_target("java/com/facebook/react/common:common"),

0 commit comments

Comments
 (0)