Skip to content

Commit 99153d8

Browse files
mateoguzmanafacebook-github-bot
authored andcommitted
Make HeadlessJsTaskSupportModule internal (#50739)
Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.modules.core.HeadlessJsTaskSupportModule). ## Changelog: [INTERNAL] - Make com.facebook.react.modules.core.HeadlessJsTaskSupportModule internal Pull Request resolved: #50739 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico Differential Revision: D73089424 Pulled By: rshest fbshipit-source-id: efad44f89679932ed6bebcf19fb2beeb096881cb
1 parent 6d8a02a commit 99153d8

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2727,12 +2727,6 @@ public class com/facebook/react/modules/core/ExceptionsManagerModule : com/faceb
27272727
public final class com/facebook/react/modules/core/ExceptionsManagerModule$Companion {
27282728
}
27292729

2730-
public class com/facebook/react/modules/core/HeadlessJsTaskSupportModule : com/facebook/fbreact/specs/NativeHeadlessJsTaskSupportSpec {
2731-
public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;)V
2732-
public fun notifyTaskFinished (D)V
2733-
public fun notifyTaskRetry (DLcom/facebook/react/bridge/Promise;)V
2734-
}
2735-
27362730
public abstract interface class com/facebook/react/modules/core/JavaScriptTimerExecutor {
27372731
public abstract fun callIdleCallbacks (D)V
27382732
public abstract fun callTimers (Lcom/facebook/react/bridge/WritableArray;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/core/HeadlessJsTaskSupportModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import com.facebook.react.module.annotations.ReactModule
1919
* it can e.g. release any resources, stop timers etc.
2020
*/
2121
@ReactModule(name = NativeHeadlessJsTaskSupportSpec.NAME)
22-
public open class HeadlessJsTaskSupportModule(reactContext: ReactApplicationContext?) :
22+
internal open class HeadlessJsTaskSupportModule(reactContext: ReactApplicationContext?) :
2323
NativeHeadlessJsTaskSupportSpec(reactContext) {
2424
override fun notifyTaskRetry(taskIdDouble: Double, promise: Promise) {
2525
val taskId = taskIdDouble.toInt()

0 commit comments

Comments
 (0)