Skip to content

Commit 97a4234

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Fix Typo and skip generation of app-specific component registration (#47547)
Summary: Pull Request resolved: #47547 In [#47176](#47176) we disabled the generation of the component registration for app specific components as it was creating a circular dependency between the app and React Native. However, we made a couple of typos that make it not work as expected and users picked up those typos soon. This change fixes them for good. ## Changelog [iOS][Fixed] - Properly stop generating component registration for components defined in app. Reviewed By: blakef Differential Revision: D65750433 fbshipit-source-id: 1a879c5be014905558b9fd05e6f16ac36b784ed6
1 parent 9db2883 commit 97a4234

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/react-native/scripts/codegen/generate-artifacts-executor.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ function rootCodegenTargetNeedsThirdPartyComponentProvider(pkgJson, platform) {
548548
function dependencyNeedsThirdPartyComponentProvider(
549549
schemaInfo,
550550
platform,
551-
appCondegenConfigSpec,
551+
appCodegenConfigSpec,
552552
) {
553553
// Filter the react native core library out.
554554
// In the future, core library and third party library should
@@ -559,7 +559,7 @@ function dependencyNeedsThirdPartyComponentProvider(
559559
// the symbols defined in the app.
560560
return (
561561
!isReactNativeCoreLibrary(schemaInfo.library.config.name, platform) &&
562-
schemaInfo.library.config.name !== appCondegenConfigSpec
562+
schemaInfo.library.config.name !== appCodegenConfigSpec
563563
);
564564
}
565565

@@ -792,7 +792,7 @@ function execute(projectRoot, targetPlatform, baseOutputPath) {
792792
dependencyNeedsThirdPartyComponentProvider(
793793
schemaInfo,
794794
platform,
795-
pkgJson.codegenConfig?.appCondegenConfigSpec,
795+
pkgJson.codegenConfig?.name,
796796
),
797797
);
798798
const schemas = filteredSchemas.map(schemaInfo => schemaInfo.schema);

0 commit comments

Comments
 (0)