Skip to content

Commit 87137ca

Browse files
mhorowitzfacebook-github-bot
authored andcommitted
rename javaModules -> nativeModules
Reviewed By: AaaChiuuu Differential Revision: D4631758 fbshipit-source-id: 3b62ada1bf32467b67cd8529d4b7873b43898ee4
1 parent e622d51 commit 87137ca

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
* view managers from).
5757
*/
5858
@ReactModuleList(
59-
javaModules = {
59+
nativeModules = {
6060
AndroidInfoModule.class,
6161
AnimationsDebugModule.class,
6262
DeviceEventManagerModule.class,

ReactAndroid/src/main/java/com/facebook/react/module/annotations/ReactModuleList.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
public @interface ReactModuleList {
2020

2121
/**
22-
* The Java modules in this list should be annotated with {@link ReactModule}.
23-
* @return List of Java modules in the package.
22+
* The Native modules in this list should be annotated with {@link ReactModule}.
23+
* @return List of Native modules in the package.
2424
*/
25-
Class<? extends NativeModule>[] javaModules();
25+
Class<? extends NativeModule>[] nativeModules();
2626

2727
/**
2828
* The View Managers in this list should be annotated with {@link ReactModule}.

ReactAndroid/src/main/java/com/facebook/react/module/processing/ReactModuleSpecProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
8787
ReactModuleList reactModuleList = typeElement.getAnnotation(ReactModuleList.class);
8888
List<String> nativeModules = new ArrayList<>();
8989
try {
90-
reactModuleList.javaModules(); // throws MirroredTypesException
90+
reactModuleList.nativeModules(); // throws MirroredTypesException
9191
} catch (MirroredTypesException mirroredTypesException) {
9292
List<? extends TypeMirror> typeMirrors = mirroredTypesException.getTypeMirrors();
9393
for (TypeMirror typeMirror : typeMirrors) {

0 commit comments

Comments
 (0)