Skip to content

Commit 86b5b4c

Browse files
cortinicofacebook-github-bot
authored andcommitted
Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release (#38212)
Summary: Pull Request resolved: #38212 This mirrors the same logic that the Hermes team has on facebook/hermes. Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release so that their CMake build is configured correctly. Their build always enables the Debugger and allows us to selectively turn it off only for release builds. More context: facebook/hermes@eabf5fcd25 Changelog: [Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release Reviewed By: cipolleschi Differential Revision: D47252735 fbshipit-source-id: 9b5cd801dea3b540a3f80b0d0975e05984f1d9b9
1 parent 58adc5e commit 86b5b4c

File tree

1 file changed

+2
-0
lines changed
  • packages/react-native/ReactAndroid/hermes-engine

1 file changed

+2
-0
lines changed

packages/react-native/ReactAndroid/hermes-engine/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ android {
191191
externalNativeBuild {
192192
cmake {
193193
arguments "-DCMAKE_BUILD_TYPE=MinSizeRel"
194+
// For release builds, we don't want to enable the Hermes Debugger.
195+
arguments "-DHERMES_ENABLE_DEBUGGER=False"
194196
}
195197
}
196198
}

0 commit comments

Comments
 (0)