Skip to content

Commit 81b1a2c

Browse files
lukaspiatkowskiFacebook Github Bot
authored andcommitted
Propagate bytecode offset in SamplingProfiler and use it to name unnamed functions
Reviewed By: cwdick Differential Revision: D4251568 fbshipit-source-id: 2343d8f6a5b2f247a7af1bbd0112bed8edadcbfe
1 parent 48b95f0 commit 81b1a2c

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

local-cli/server/middleware/jscProfilerMiddleware.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,13 @@ class TreeTransformator {
5050
line: tree.lineNumber,
5151
column: tree.columnNumber,
5252
});
53-
tree.functionName = tree.functionName || original.name
53+
const functionName = original.name
5454
|| (path.posix.basename(original.source || '') + ':' + original.line);
55+
if (tree.functionName === '(unnamed builtin)') {
56+
tree.functionName += ':' + functionName;
57+
} else {
58+
tree.functionName = tree.functionName || functionName;
59+
}
5560
tree.scriptId = tree.id;
5661
tree.url = 'file://' + original.source;
5762
tree.lineNumber = original.line;

0 commit comments

Comments
 (0)