Skip to content

Commit 6f9ddd8

Browse files
cipolleschiblakef
authored andcommitted
Add yoga to app search paths (#47195)
Summary: Pull Request resolved: #47195 When a user wants to create a Fabric Component i their app (not in a separate library) the app fails to build because: - The custom component has to inherit from `RCTViewComponentView` - `RCTViewComponentView` imports `ViewProps.h` - `ViewProps.h` imports `HostPlatformViewProps.h` - `HostPlatformViewProps.h` imports `BaseViewProps.h` - `BaseViewProps.h` imports `YogaStylableProps.h` which is a Yoga private header and the App has not visibility over it. It is also not possible to fix this issue with forward declaring the `YogaStylableProps`, because `BaseViewProps` inherit from the yoga's props, so the compiler needs the full declaration of `YogaStylableProps` to work This needs to be picked in 0.76 ## Changelog [iOS][Fixed] - Give apps access to Yoga headers Reviewed By: blakef Differential Revision: D64925222 fbshipit-source-id: e724076bbfb0a678948340dfab2ce609e6509533
1 parent 3ce4b80 commit 6f9ddd8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/Libraries/AppDelegate/React-RCTAppDelegate.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Pod::Spec.new do |s|
6363
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
6464
"DEFINES_MODULE" => "YES"
6565
}
66-
s.user_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/Headers/Private/React-Core\""}
66+
s.user_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/Headers/Private/React-Core\" \"$(PODS_ROOT)/Headers/Private/Yoga\""}
6767

6868
s.dependency "React-Core"
6969
s.dependency "RCT-Folly", folly_version

0 commit comments

Comments
 (0)