Fix crash when changing animated values

Author: janicduplessis

Libraries/NativeAnimation/Nodes/RCTPropsAnimatedNode.m

@@ -77,8 +77,10 @@ - (void)performUpdate
 {
   [super performUpdate];
 
+  // Since we are connecting nodes before attaching them to views there is a time where it's
+  // possible that the connected view has not been set yet, this is normal and we can simply
+  // skip that update.
   if (!_connectedViewTag) {
-    RCTLogError(@"Node has not been attached to a view");
     return;
   }
 

Libraries/NativeAnimation/RCTNativeAnimatedModule.m

@@ -60,23 +60,23 @@ - (void)setBridge:(RCTBridge *)bridge
 RCT_EXPORT_METHOD(createAnimatedNode:(nonnull NSNumber *)tag
                   config:(NSDictionary<NSString *, id> *)config)
 {
-  [self addOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
+  [self addPreOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
     [nodesManager createAnimatedNode:tag config:config];
   }];
 }
 
 RCT_EXPORT_METHOD(connectAnimatedNodes:(nonnull NSNumber *)parentTag
                   childTag:(nonnull NSNumber *)childTag)
 {
-  [self addOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
+  [self addPreOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
     [nodesManager connectAnimatedNodes:parentTag childTag:childTag];
   }];
 }
 
 RCT_EXPORT_METHOD(disconnectAnimatedNodes:(nonnull NSNumber *)parentTag
                   childTag:(nonnull NSNumber *)childTag)
 {
-  [self addOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
+  [self addPreOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
     [nodesManager disconnectAnimatedNodes:parentTag childTag:childTag];
   }];
 }
@@ -150,7 +150,7 @@ - (void)setBridge:(RCTBridge *)bridge
 
 RCT_EXPORT_METHOD(dropAnimatedNode:(nonnull NSNumber *)tag)
 {
-  [self addOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
+  [self addPreOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
     [nodesManager dropAnimatedNode:tag];
   }];
 }