Skip to content

Commit 4f01e87

Browse files
cipolleschicoado
andauthored
[Local] Fix CI for 0.79-stable (#51804)
Co-authored-by: Dawid Małecki <[email protected]> resolved: #51382
1 parent 76f3d5c commit 4f01e87

File tree

6 files changed

+74
-867
lines changed

6 files changed

+74
-867
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"test-e2e-local-clean": "node ./scripts/release-testing/test-e2e-local-clean.js",
3030
"test-e2e-local": "node ./scripts/release-testing/test-e2e-local.js",
3131
"test-ios": "./scripts/objc-test.sh test",
32-
"test-typescript-offline": "dtslint --localTs node_modules/typescript/lib packages/react-native/types",
33-
"test-typescript": "dtslint packages/react-native/types",
32+
"test-typescript": "tsc -p packages/react-native/types/tsconfig.test.json",
3433
"test": "jest",
3534
"fantom": "JS_DIR='..' yarn jest --config packages/react-native-fantom/config/jest.config.js",
3635
"trigger-react-native-release": "node ./scripts/releases-local/trigger-react-native-release.js",
@@ -49,7 +48,6 @@
4948
"@babel/plugin-transform-regenerator": "^7.24.7",
5049
"@babel/preset-env": "^7.25.3",
5150
"@babel/preset-flow": "^7.24.7",
52-
"@definitelytyped/dtslint": "^0.0.127",
5351
"@jest/create-cache-key-function": "^29.7.0",
5452
"@react-native/metro-babel-transformer": "0.79.2",
5553
"@react-native/metro-config": "0.79.2",

packages/react-native/scripts/codegen/generate-artifacts-executor.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ function findLibrariesFromReactNativeConfig(projectRoot, rnConfig) {
360360
*
361361
* This is needed when selectively disabling libraries in react-native.config.js since codegen should exclude those libraries as well.
362362
*/
363-
function findDisabledLibrariesByPlatform(reactNativeConfig, platform) {
363+
function findDisabledLibrariesByPlatform(reactNativeConfig, platform) {
364364
const dependencies = reactNativeConfig.dependencies ?? {};
365365

366366
return Object.keys(dependencies).filter(
@@ -610,7 +610,7 @@ function findCodegenEnabledLibraries(pkgJson, projectRoot, reactNativeConfig) {
610610
}
611611

612612
function readReactNativeConfig(projectRoot) {
613-
const rnConfigFilePath = path.resolve(projectRoot, 'react-native.config.js');Add commentMore actions
613+
const rnConfigFilePath = path.resolve(projectRoot, 'react-native.config.js');
614614

615615
if (!fs.existsSync(rnConfigFilePath)) {
616616
return {};
@@ -1071,7 +1071,11 @@ function execute(projectRoot, targetPlatform, baseOutputPath, source) {
10711071
buildCodegenIfNeeded();
10721072

10731073
const reactNativeConfig = readReactNativeConfig(projectRoot);
1074-
const codegenEnabledLibraries = findCodegenEnabledLibraries(pkgJson, projectRoot, reactNativeConfig);
1074+
const codegenEnabledLibraries = findCodegenEnabledLibraries(
1075+
pkgJson,
1076+
projectRoot,
1077+
reactNativeConfig,
1078+
);
10751079

10761080
if (codegenEnabledLibraries.length === 0) {
10771081
codegenLog('No codegen-enabled libraries found.', true);
@@ -1082,7 +1086,7 @@ function execute(projectRoot, targetPlatform, baseOutputPath, source) {
10821086
targetPlatform === 'all' ? supportedPlatforms : [targetPlatform];
10831087

10841088
for (const platform of platforms) {
1085-
const disabledLibraries = findDisabledLibrariesByPlatform(Add commentMore actions
1089+
const disabledLibraries = findDisabledLibrariesByPlatform(
10861090
reactNativeConfig,
10871091
platform,
10881092
);

packages/react-native/types/index.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
/// <reference path="../src/types/globals.d.ts" />
7272
/// <reference path="modules/LaunchScreen.d.ts" />
7373

74-
7574
export * from '../Libraries/ActionSheetIOS/ActionSheetIOS';
7675
export * from '../Libraries/Alert/Alert';
7776
export * from '../Libraries/Animated/Animated';
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"compilerOptions": {
3+
"module": "commonjs",
4+
"lib": ["es6"],
5+
"noImplicitAny": true,
6+
"noImplicitThis": true,
7+
"strictFunctionTypes": true,
8+
"strictNullChecks": true,
9+
"types": [],
10+
"jsx": "react",
11+
"noEmit": true,
12+
"forceConsistentCasingInFileNames": true,
13+
"paths": {"react-native": ["."]}
14+
},
15+
"include": ["../**/*.d.ts", "__typetests__/**/*"]
16+
}

scripts/run-ci-javascript-tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ try {
103103
}
104104

105105
describe('Test: TypeScript tests');
106-
if (exec(`${YARN_BINARY} run test-typescript-offline`).code) {
106+
if (exec(`${YARN_BINARY} run test-typescript`).code) {
107107
echo('Failed to run TypeScript tests.');
108108
exitCode = 1;
109109
throw Error(exitCode);

0 commit comments

Comments
 (0)