packager: GlobalTransformCache: retry keys fetches

Jean Lauliac · facebook-github-bot · commit 33000c74f9b0 · 2017-03-28T11:01:53.000-07:00
Reviewed By: davidaurelio

Differential Revision: D4779641

fbshipit-source-id: 1b156bf075fa2456d9e6b1a3f38855357abc1abb
diff --git a/packager/src/lib/GlobalTransformCache.js b/packager/src/lib/GlobalTransformCache.js
@@ -239,13 +239,17 @@ class GlobalTransformCache {
    */
   static fetchResultFromURI(uri: string): Promise<CachedResult> {
     return GlobalTransformCache._fetchResultFromURI(uri).catch(error => {
-      if (!(error instanceof FetchError && error.type === 'request-timeout')) {
+      if (!GlobalTransformCache.isTimeoutError(error)) {
         throw error;
       }
       return this._fetchResultFromURI(uri);
     });
   }
 
+  static isTimeoutError(error: Error): boolean {
+    return error instanceof FetchError && error.type === 'request-timeout';
+  }
+
   shouldFetch(props: FetchProps): boolean {
     return this._profileSet.has(props.transformOptions);
   }

Original file line number	Diff line number	Diff line change
`@@ -239,13 +239,17 @@ class GlobalTransformCache {`
`239`	`239`	`*/`
`240`	`240`	`static fetchResultFromURI(uri: string): Promise<CachedResult> {`
`241`	`241`	`return GlobalTransformCache._fetchResultFromURI(uri).catch(error => {`
`242`		`- if (!(error instanceof FetchError && error.type === 'request-timeout')) {`
	`242`	`+ if (!GlobalTransformCache.isTimeoutError(error)) {`
`243`	`243`	`throw error;`
`244`	`244`	`}`
`245`	`245`	`return this._fetchResultFromURI(uri);`
`246`	`246`	`});`
`247`	`247`	`}`
`248`	`248`
	`249`	`+ static isTimeoutError(error: Error): boolean {`
	`250`	`+ return error instanceof FetchError && error.type === 'request-timeout';`
	`251`	`+ }`
	`252`	`+`
`249`	`253`	`shouldFetch(props: FetchProps): boolean {`
`250`	`254`	`return this._profileSet.has(props.transformOptions);`
`251`	`255`	`}`