Skip to content

Commit 2c752af

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Fix Windows CI (#52666)
Summary: As per [this issue](actions/runner-images#12416), Windows machine doesn't have access to D: drive anymore ## Changelog: [Internal] - Pull Request resolved: #52666 Test Plan: GHA Reviewed By: huntie Differential Revision: D78484060 Pulled By: cipolleschi fbshipit-source-id: 36d844f9d7d69f1d74a154b019307cc1e269ad66
1 parent b6f4142 commit 2c752af

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

.github/actions/build-hermesc-windows/action.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,23 @@ runs:
1414
uses: actions/download-artifact@v4
1515
with:
1616
name: hermes-workspace
17-
path: 'D:\tmp\hermes'
17+
path: 'C:\tmp\hermes'
1818
- name: Set up workspace
1919
shell: powershell
2020
run: |
21-
mkdir -p D:\tmp\hermes\osx-bin
21+
mkdir -p C:\tmp\hermes\osx-bin
2222
mkdir -p .\packages\react-native\sdks\hermes
23-
cp -r -Force D:\tmp\hermes\hermes\* .\packages\react-native\sdks\hermes\.
23+
cp -r -Force C:\tmp\hermes\hermes\* .\packages\react-native\sdks\hermes\.
2424
cp -r -Force .\packages\react-native\sdks\hermes-engine\utils\* .\packages\react-native\sdks\hermes\.
2525
- name: Windows cache
2626
uses: actions/cache@v4
2727
with:
2828
key: v3-hermes-${{ github.job }}-windows-${{ inputs.hermes-version }}-${{ inputs.react-native-version }}
2929
path: |
30-
D:\tmp\hermes\win64-bin\
31-
D:\tmp\hermes\hermes\icu\
32-
D:\tmp\hermes\hermes\deps\
33-
D:\tmp\hermes\hermes\build_release\
30+
C:\tmp\hermes\win64-bin\
31+
C:\tmp\hermes\hermes\icu\
32+
C:\tmp\hermes\hermes\deps\
33+
C:\tmp\hermes\hermes\build_release\
3434
- name: setup-msbuild
3535
uses: microsoft/[email protected]
3636
- name: Set up workspace
@@ -83,4 +83,4 @@ runs:
8383
uses: actions/[email protected]
8484
with:
8585
name: hermes-win64-bin
86-
path: D:\tmp\hermes\win64-bin\
86+
path: C:\tmp\hermes\win64-bin\

.github/workflows/nightly.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ jobs:
128128
runs-on: windows-2025
129129
needs: prepare_hermes_workspace
130130
env:
131-
HERMES_WS_DIR: 'D:\tmp\hermes'
132-
HERMES_TARBALL_ARTIFACTS_DIR: 'D:\tmp\hermes\hermes-runtime-darwin'
133-
HERMES_OSXBIN_ARTIFACTS_DIR: 'D:\tmp\hermes\osx-bin'
131+
HERMES_WS_DIR: 'C:\tmp\hermes'
132+
HERMES_TARBALL_ARTIFACTS_DIR: 'C:\tmp\hermes\hermes-runtime-darwin'
133+
HERMES_OSXBIN_ARTIFACTS_DIR: 'C:\tmp\hermes\osx-bin'
134134
ICU_URL: "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-Win64-MSVC2017.zip"
135135
MSBUILD_DIR: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin'
136136
CMAKE_DIR: 'C:\Program Files\CMake\bin'

.github/workflows/publish-release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@ jobs:
125125
runs-on: windows-2025
126126
needs: prepare_hermes_workspace
127127
env:
128-
HERMES_WS_DIR: 'D:\tmp\hermes'
129-
HERMES_TARBALL_ARTIFACTS_DIR: 'D:\tmp\hermes\hermes-runtime-darwin'
130-
HERMES_OSXBIN_ARTIFACTS_DIR: 'D:\tmp\hermes\osx-bin'
128+
HERMES_WS_DIR: 'C:\tmp\hermes'
129+
HERMES_TARBALL_ARTIFACTS_DIR: 'C:\tmp\hermes\hermes-runtime-darwin'
130+
HERMES_OSXBIN_ARTIFACTS_DIR: 'C:\tmp\hermes\osx-bin'
131131
ICU_URL: "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-Win64-MSVC2017.zip"
132132
MSBUILD_DIR: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin'
133133
CMAKE_DIR: 'C:\Program Files\CMake\bin'

.github/workflows/test-all.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -382,9 +382,9 @@ jobs:
382382
runs-on: windows-2025
383383
needs: prepare_hermes_workspace
384384
env:
385-
HERMES_WS_DIR: 'D:\tmp\hermes'
386-
HERMES_TARBALL_ARTIFACTS_DIR: 'D:\tmp\hermes\hermes-runtime-darwin'
387-
HERMES_OSXBIN_ARTIFACTS_DIR: 'D:\tmp\hermes\osx-bin'
385+
HERMES_WS_DIR: 'C:\tmp\hermes'
386+
HERMES_TARBALL_ARTIFACTS_DIR: 'C:\tmp\hermes\hermes-runtime-darwin'
387+
HERMES_OSXBIN_ARTIFACTS_DIR: 'C:\tmp\hermes\osx-bin'
388388
ICU_URL: "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-Win64-MSVC2017.zip"
389389
MSBUILD_DIR: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin'
390390
CMAKE_DIR: 'C:\Program Files\CMake\bin'

packages/gradle-plugin/shared/src/test/kotlin/com/facebook/react/utils/OsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class OsTest {
5555

5656
@Test
5757
fun unixifyPath_withAWindowsPath_convertsItCorrectly() {
58-
val aWindowsPath = "D:\\just\\a\\windows\\path\\"
58+
val aWindowsPath = "C:\\just\\a\\windows\\path\\"
5959

6060
assertThat("/D/just/a/windows/path/").isEqualTo(aWindowsPath.unixifyPath())
6161
}

0 commit comments

Comments
 (0)