Skip to content

Commit 23c2a6c

Browse files
sherginfacebook-github-bot
authored andcommitted
Removed harmful optimization in ReactNativeEventEmitter
Reviewed By: spicyj Differential Revision: D4729779 fbshipit-source-id: 2dd5ec10d42df7f24804796c4100eca107edeedb
1 parent 47d2cfe commit 23c2a6c

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

Libraries/Renderer/src/renderers/native/ReactNativeEventEmitter.js

-5
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,6 @@ var ReactNativeEventEmitter = {
103103
) {
104104
var nativeEvent = nativeEventParam || EMPTY_NATIVE_EVENT;
105105
var inst = ReactNativeComponentTree.getInstanceFromNode(rootNodeID);
106-
if (!inst) {
107-
// If the original instance is already gone, we don't have to dispatch
108-
// any events.
109-
return;
110-
}
111106
ReactGenericBatching.batchedUpdates(function() {
112107
ReactNativeEventEmitter.handleTopLevel(
113108
topLevelType,

Libraries/Renderer/src/renderers/shared/shared/event/EventPropagators.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ function accumulateTwoPhaseDispatchesSingleSkipTarget(event) {
9393
* requiring that the `dispatchMarker` be the same as the dispatched ID.
9494
*/
9595
function accumulateDispatches(inst, ignoredDirection, event) {
96-
if (event && event.dispatchConfig.registrationName) {
96+
if (inst && event && event.dispatchConfig.registrationName) {
9797
var registrationName = event.dispatchConfig.registrationName;
9898
var listener = getListener(inst, registrationName);
9999
if (listener) {

0 commit comments

Comments
 (0)