Fix crash in RCTRedBox::formatFrameSource:

terribleben · ide · commit 1a23902c604b · 2017-04-07T12:03:18.000-07:00
Summary: Motivation: Similar to #13242 - the application will crash with `[NSNull lastPathComponent]: unrecognized selector sent to instance` if a stack frame with no filename makes it to RCTRedBox. Closes #13360 Differential Revision: D4848980 Pulled By: javache fbshipit-source-id: dc506f2ba39c2d4d68982b56a6e765a19dc048b0
diff --git a/React/Modules/RCTRedBox.m b/React/Modules/RCTRedBox.m
@@ -185,8 +185,9 @@ - (void)copyStack
 
 - (NSString *)formatFrameSource:(RCTJSStackFrame *)stackFrame
 {
+  NSString *fileName = RCTNilIfNull(stackFrame.file) ? [stackFrame.file lastPathComponent] : @"<unknown file>";
   NSString *lineInfo = [NSString stringWithFormat:@"%@:%zd",
-                        [stackFrame.file lastPathComponent],
+                        fileName,
                         stackFrame.lineNumber];
 
   if (stackFrame.column != 0) {

Original file line number	Diff line number	Diff line change
`@@ -185,8 +185,9 @@ - (void)copyStack`
`185`	`185`
`186`	`186`	`- (NSString )formatFrameSource:(RCTJSStackFrame )stackFrame`
`187`	`187`	`{`
	`188`	`+ NSString *fileName = RCTNilIfNull(stackFrame.file) ? [stackFrame.file lastPathComponent] : @"<unknown file>";`
`188`	`189`	`NSString *lineInfo = [NSString stringWithFormat:@"%@:%zd",`
`189`		`- [stackFrame.file lastPathComponent],`
	`190`	`+ fileName,`
`190`	`191`	`stackFrame.lineNumber];`
`191`	`192`
`192`	`193`	`if (stackFrame.column != 0) {`