Fix RCTPicker crash

ShiHui · facebook-github-bot · commit 1195a8f3e6d4 · 2017-03-14T17:46:24.000-07:00
Summary: If user slide picker when picker item is zero, `UIPickerViewDelegate` will call `pickerView:didSelectRow:inComponent` row=0, `_items[row][@"value"]` will crash. Closes #12187 Differential Revision: D4709882 Pulled By: mkonicek fbshipit-source-id: 772c819d4eaef41ac983287877bda2918f40b1a7
diff --git a/React/Views/RCTPicker.m b/React/Views/RCTPicker.m
@@ -98,7 +98,7 @@ - (void)pickerView:(__unused UIPickerView *)pickerView
       didSelectRow:(NSInteger)row inComponent:(__unused NSInteger)component
 {
   _selectedIndex = row;
-  if (_onChange) {
+  if (_onChange && _items.count > row) {
     _onChange(@{
       @"newIndex": @(row),
       @"newValue": RCTNullIfNil(_items[row][@"value"]),

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ - (void)pickerView:(__unused UIPickerView *)pickerView`
`98`	`98`	`didSelectRow:(NSInteger)row inComponent:(__unused NSInteger)component`
`99`	`99`	`{`
`100`	`100`	`_selectedIndex = row;`
`101`		`- if (_onChange) {`
	`101`	`+ if (_onChange && _items.count > row) {`
`102`	`102`	`_onChange(@{`
`103`	`103`	`@"newIndex": @(row),`
`104`	`104`	`@"newValue": RCTNullIfNil(_items[row][@"value"]),`