Change Buf -> BufPtr and RawBuf -> Buf

Summary:
Previously,
* `RawBuf` was a typealias for `std::unique_ptr<folly::IOBuf>`
* `Buf` was a typealias for `folly::IOBuf`

In this diff,
* `Buf` is a typealias for `folly::IOBuf`
* `BufPtr` is a typealias for `std::unique_ptr<folly::IOBuf>`

Reviewed By: hanidamlaj

Differential Revision: D73206576

fbshipit-source-id: 454bf6ccfce3d6571e5e931889263ed98cc24af3

Author: Aman Sharma

proxygen/httpserver/samples/hq/HQClient.cpp

@@ -250,7 +250,7 @@ void HQClient::sendKnobFrame(const folly::StringPiece str) {
   }
   uint64_t knobSpace = 0xfaceb00c;
   uint64_t knobId = 100;
-  Buf buf(folly::IOBuf::create(str.size()));
+  BufPtr buf(folly::IOBuf::create(str.size()));
   memcpy(buf->writableData(), str.data(), str.size());
   buf->append(str.size());
   VLOG(10) << "Sending Knob Frame to peer. KnobSpace: " << std::hex << knobSpace

proxygen/httpserver/samples/hq/HQServerModule.cpp

@@ -20,7 +20,7 @@ void sendKnobFrame(HQSession* session, const folly::StringPiece str) {
   }
   uint64_t knobSpace = 0xfaceb00c;
   uint64_t knobId = 200;
-  quic::Buf buf(folly::IOBuf::create(str.size()));
+  quic::BufPtr buf(folly::IOBuf::create(str.size()));
   memcpy(buf->writableData(), str.data(), str.size());
   buf->append(str.size());
   VLOG(10) << "Sending Knob Frame to peer. KnobSpace: " << std::hex << knobSpace

proxygen/lib/http/session/HQSession.cpp

@@ -283,7 +283,7 @@ void HQSession::onStopSending(quic::StreamId id,
 
 void HQSession::onKnob(uint64_t knobSpace,
                        uint64_t knobId,
-                       quic::Buf knobBlob) {
+                       quic::BufPtr knobBlob) {
   VLOG(3) << __func__ << " sess=" << *this
           << " knob frame received: " << " KnobSpace: " << std::hex << knobSpace
           << " KnobId: " << knobId << " KnobBlob: "
@@ -1295,7 +1295,7 @@ void HQSession::readControlStream(HQControlStream* ctrlStream) {
     return;
   }
   resetTimeout();
-  quic::Buf data = std::move(readRes.value().first);
+  quic::BufPtr data = std::move(readRes.value().first);
   auto readSize = data ? data->computeChainDataLength() : 0;
   VLOG(4) << "Read " << readSize << " bytes from control stream";
   ctrlStream->readBuf_.append(std::move(data));
@@ -1443,7 +1443,7 @@ void HQSession::readRequestStream(quic::StreamId id) noexcept {
   }
 
   resetTimeout();
-  quic::Buf data = std::move(readRes.value().first);
+  quic::BufPtr data = std::move(readRes.value().first);
   auto readSize = data ? data->computeChainDataLength() : 0;
   hqStream->readEOF_ = readRes.value().second;
   VLOG(3) << "Got streamID=" << hqStream->getStreamId() << " len=" << readSize
@@ -3814,8 +3814,8 @@ HQSession::HQStreamTransport::sendDatagram(
   //   [Context ID (i)],
   //   HTTP/3 Datagram Payload (..),
   // }
-  quic::Buf headerBuf =
-      quic::Buf(folly::IOBuf::create(session_.sock_->getDatagramSizeLimit()));
+  quic::BufPtr headerBuf = quic::BufPtr(
+      folly::IOBuf::create(session_.sock_->getDatagramSizeLimit()));
   quic::BufAppender appender(headerBuf.get(), kMaxDatagramHeaderSize);
   auto streamIdRes = quic::encodeQuicInteger(
       streamId_.value() / 4, [&](auto val) { appender.writeBE(val); });

proxygen/lib/http/session/HQSession.h

@@ -195,7 +195,9 @@ class HQSession
 
   void onConnectionError(quic::QuicError code) noexcept override;
 
-  void onKnob(uint64_t knobSpace, uint64_t knobId, quic::Buf knobBlob) override;
+  void onKnob(uint64_t knobSpace,
+              uint64_t knobId,
+              quic::BufPtr knobBlob) override;
 
   // returns false in case of failure
   bool onTransportReadyCommon() noexcept;
@@ -374,7 +376,7 @@ class HQSession
    * Sends a knob frame on the session.
    */
   folly::Expected<folly::Unit, quic::LocalErrorCode> sendKnob(
-      uint64_t knobSpace, uint64_t knobId, quic::Buf knobBlob) {
+      uint64_t knobSpace, uint64_t knobId, quic::BufPtr knobBlob) {
     return sock_->setKnob(knobSpace, knobId, std::move(knobBlob));
   }
 

proxygen/lib/http/session/test/HQSessionTestCommon.h

@@ -373,7 +373,7 @@ class HQSessionTest
     //   [Context ID (i)],
     //   HTTP/3 Datagram Payload (..),
     // }
-    quic::Buf headerBuf = quic::Buf(folly::IOBuf::create(0));
+    quic::BufPtr headerBuf = quic::BufPtr(folly::IOBuf::create(0));
     quic::BufAppender appender(headerBuf.get(),
                                proxygen::kMaxDatagramHeaderSize);
     auto streamIdRes = quic::encodeQuicInteger(

proxygen/lib/http/session/test/MockQuicSocketDriver.h

@@ -464,7 +464,7 @@ class MockQuicSocketDriver : public folly::EventBase::LoopCallback {
 
     EXPECT_CALL(*sock_, readDatagramBufs(testing::_))
         .WillRepeatedly(testing::Invoke(
-            [this](size_t atMost) -> folly::Expected<std::vector<quic::Buf>,
+            [this](size_t atMost) -> folly::Expected<std::vector<quic::BufPtr>,
                                                      quic::LocalErrorCode> {
               auto& connStream = streams_[kConnectionStreamId];
               if (connStream.writeState == CLOSED) {
@@ -476,7 +476,7 @@ class MockQuicSocketDriver : public folly::EventBase::LoopCallback {
               } else {
                 atMost = std::min(atMost, inDatagrams_.size());
               }
-              std::vector<Buf> retDatagrams;
+              std::vector<BufPtr> retDatagrams;
               retDatagrams.reserve(atMost);
               std::transform(
                   inDatagrams_.begin(),

proxygen/lib/http/webtransport/WebTransportImpl.cpp

@@ -257,7 +257,7 @@ void WebTransportImpl::StreamReadHandle::readAvailable(
     impl_.wtIngressStreams_.erase(getID());
     return;
   }
-  quic::Buf data = std::move(readRes.value().first);
+  quic::BufPtr data = std::move(readRes.value().first);
   bool eof = readRes.value().second;
   // deliver data, eof
   auto state = dataAvailable(std::move(data), eof);