Avoid a copy in response builder

yuandagits · facebook-github-bot · commit c6729669d260 · 2025-04-23T18:44:51.000-07:00
Summary: We're calling `folly::to<std::string>` and passing the output of that into maybeCopyBuffer. Instead, we can use `folly::IOBuf::fromString` which will destructively consume the string wp post: https://fb.workplace.com/groups/218959637537866/permalink/3534280696879296/ Reviewed By: hanidamlaj, NikhilCollooru Differential Revision: D73537785 fbshipit-source-id: 36abbb3dc7ca00189f36bfd1f782ac6dd8cc2125
diff --git a/proxygen/httpserver/ResponseBuilder.h b/proxygen/httpserver/ResponseBuilder.h
@@ -117,8 +117,8 @@ class ResponseBuilder {
 
   template <typename T>
   ResponseBuilder& body(T&& t) {
-    return body(folly::IOBuf::maybeCopyBuffer(
-        folly::to<std::string>(std::forward<T>(t))));
+    return body(
+        folly::IOBuf::fromString(folly::to<std::string>(std::forward<T>(t))));
   }
 
   ResponseBuilder& closeConnection() {

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,8 @@ class ResponseBuilder {`
`117`	`117`
`118`	`118`	`template <typename T>`
`119`	`119`	`ResponseBuilder& body(T&& t) {`
`120`		`- return body(folly::IOBuf::maybeCopyBuffer(`
`121`		`- folly::to<std::string>(std::forward<T>(t))));`
	`120`	`+ return body(`
	`121`	`+ folly::IOBuf::fromString(folly::to<std::string>(std::forward<T>(t))));`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`ResponseBuilder& closeConnection() {`