v.decimal() requires a leading zero to be considered a valid decimal

[asg86260]

I threw together an example using the valibot playground.

.1 throws an error
0.1 is fine.

import * as v from 'valibot';

const Schema = v.object({
  noLeadingZero: v.pipe(v.string(), v.decimal()),
  leadingZero: v.pipe(v.string(), v.decimal()),
});

const result = v.safeParse(Schema, {
  noLeadingZero: '.1',
  leadingZero: '0.1',
});

console.log(result);

and the output here

{
  typed: true,
  success: false,
  output: {
    noLeadingZero: ".1",
    leadingZero: "0.1"
  },
  issues: [
    {
      kind: "validation",
      type: "decimal",
      input: ".1",
      expected: null,
      received: "\".1\"",
      message: "Invalid decimal: Received \".1\"",
      requirement: RegExp,
      path: [
        {
          type: "object",
          origin: "value",
          input: {
            noLeadingZero: ".1",
            leadingZero: "0.1"
          },
          key: "noLeadingZero",
          value: ".1"
        }
      ],
      issues: undefined,
      lang: undefined,
      abortEarly: undefined,
      abortPipeEarly: undefined
    }
  ]
}

[fabian-hiller]

Thank you for creating this issue. I am not sure if we should change this. The .1 thing seems to be more or less a programming thing. What do you think?

In the meantime regex with a modified version of the DECIMAL_REGEX can be used.

[asg86260]

Thanks for replying so quickly!

Yea, I honestly wasn't sure if this was intended behavior or not. In our case a user types in .1 into some form. which seems like a valid decimal input, but the validation for v.decimal is saying its incorrect. I can see arguments for both sides, and ill defer to yall.

we can totally work with a regex modification if that behavior is intended.

[fabian-hiller]

Hey, I thought about it and think that we should probably make the number before the . somehow optional. Would you be interested in creating a PR that updates the regex and tests?

[fabian-hiller]

I will create a PR

[asg86260]

nice, sorry I couldn't find time for this last week. i appreciate the update!