AzureKeyVault integration with Azure Govcloud not working

[lovleshmalik]

Hi,
I was trying ExternalSecret with Azure keyvault located in US GovCloud.
The yaml expects a parameter named "keyVaultName": mykeyvault, which specifies the name of keyvault.
When trying to fetch credentials from keyvault, the URL that is hit is automatically composed from this as
https://mykeyvault.vault.azure.net/secrets/secret1/?api-version=7.1
This means that it is assuming my keyvault is located in public cloud.
My question is , do we have some sort of parameter to tell it to use different cloud, or if that is not an option, can I somehow tell it to pick different endpoint instead of ".vault.azure.net" ?

[moolen]

currently, this is hard-coded. You could make that configurable here. Also, there's a external-secrets rewrite in go. Unfortunately, the Azure KV provider is not ready yet (but will be very soon): https://github.com/external-secrets/external-secrets

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity.

[ericabramov]

Contributing a fix for that:
#871