Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

feat(Multitenancy): scope KES access using ExternalSecret config #701

Conversation

aabouzaid
Copy link
Contributor

@aabouzaid aabouzaid commented Apr 9, 2021

As discussed in PR #549 but using the spec.controllerId instead of the annotation as @Flydiverny suggested.

@aabouzaid
Copy link
Contributor Author

One side note here, on the controller side, I'm not sure if Instance ID is a good name or it should be Controller ID ... I just found it a bit confusing if it has the same name as in the ExternalSecret config.

I have no strong opinion about it and could change it.

Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time! 🎉
Regarding instance id vs controller id no really opinion here either, we can do like this it makes sense to me 😄

@aabouzaid
Copy link
Contributor Author

Thanks for taking the time! tada
Regarding instance id vs controller id no really opinion here either, we can do like this it makes sense to me smile

Thanks a lot for your feedback 🙇
All of your comments have been addressed ✔️

@aabouzaid aabouzaid requested a review from Flydiverny April 10, 2021 02:06
@Flydiverny Flydiverny merged commit af50ca6 into external-secrets:master Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants