This repository was archived by the owner on Jul 26, 2022. It is now read-only.
feat(helm): add in ability to inject init containers in to deployment from values #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismellard
force-pushed
the
master
branch
3 times, most recently
from
fac4b23 to
aabe0a6
Compare
Flydiverny
reviewed
Feb 5, 2021
|
|
||
| deploymentInitContainers: {} | ||
|
|
||
| emptyDirVolumes: {} |
There was a problem hiding this comment.
Can we do more generic and add extraVolumeMounts and extraVolumes instead ? :)
There was a problem hiding this comment.
Updated the PR to reflect your suggestion. Thanks for the review 👍
Flydiverny
changed the title
rawlingsj
added a commit
to rawlingsj/jx-gitops
that referenced
this pull request
Feb 8, 2021
this is while we wait for PR external-secrets/kubernetes-external-secrets#615 to merge
Flydiverny
reviewed
Feb 9, 2021
Comment on lines
68
to
70
| {{- with .Values.extraVolumeMounts }} | ||
| {{- range $key, $value := . }} | ||
| - name: {{ $key }} | ||
| mountPath: {{ $value.mountPath }} | ||
| readOnly: {{ $value.readOnly }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Think we could simplify this
Suggested change
| {{- with .Values.extraVolumeMounts }} | |
| {{- range $key, $value := . }} | |
| - name: {{ $key }} | |
| mountPath: {{ $value.mountPath }} | |
| readOnly: {{ $value.readOnly }} | |
| {{- end }} | |
| {{- end }} | |
| {{- if .Values.extraVolumeMounts }} | |
| {{ toYaml .Values.extraVolumes | nindent 12 }} | |
| {{- end }} |
Comment on lines
108
to
106
| {{- with .Values.extraVolumes }} | ||
| {{- range $key, $value := . }} | ||
| - name: {{ $key }} | ||
| {{- toYaml $value | nindent 8 }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Think we could simplify this
Suggested change
| {{- with .Values.extraVolumes }} | |
| {{- range $key, $value := . }} | |
| - name: {{ $key }} | |
| {{- toYaml $value | nindent 8 }} | |
| {{- end }} | |
| {{- end }} | |
| {{- if .Values.extraVolumes }} | |
| {{ toYaml .Values.extraVolumes | nindent 8 }} | |
| {{- end }} |
Comment on lines
133
to
140
| #extraVolumes: | ||
| # namedVolume: | ||
| # emptyDir: {} | ||
| # | ||
| #extraVolumeMounts: | ||
| # namedVolume: | ||
| # mountPath: /usr/path | ||
| # readOnly: false |
There was a problem hiding this comment.
Suggested change
| #extraVolumes: | |
| # namedVolume: | |
| # emptyDir: {} | |
| # | |
| #extraVolumeMounts: | |
| # namedVolume: | |
| # mountPath: /usr/path | |
| # readOnly: false | |
| extraVolumes: [] | |
| # - name: namedVolume | |
| # emptyDir: {} | |
| # | |
| extraVolumeMounts: [] | |
| # - name: namedVolume | |
| # mountPath: /usr/path | |
| # readOnly: false |
There was a problem hiding this comment.
All good - more likely me out of the loop ;) Updated.
Flydiverny
approved these changes
Feb 9, 2021
|
Hold off. spotted one problem |
…values chore: added in jetbrains ignore files x
|
Resolved. Was outputting volumes yaml in volumeMounts block :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.