This repository was archived by the owner on Jul 26, 2022. It is now read-only.
feat: Cluster level default settings for Hashicorp Vault #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables global default
Vault Role
andVault Mount Point
setting for k8s authentication to Hashicorp Vault.Reason:
When a user tries to deploy an app to multiple different cluster which uses the same vault. The
External Secret
yaml file has differences since,vaultRole
andvaultMountPoint
could be different for different clusters. This leads to multipleExternal Secret
yaml file. One for each cluster. Whereas this could be specified during deployment of External Secret helm chart.Since, a cluster will most probably will have one
vaultMountPoint
. It is better to have a way to deploy it at the config level. Leaving the user not to worry about role and mount point and focus on the values retrieved from the vault. Since, it is a default value. This will be backwards compatible with the previous method as it can be overwritten with the value in theExternal Secret
manifest file.