Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

feat: Cluster level default settings for Hashicorp Vault #472

Merged
merged 1 commit into from
Sep 25, 2020
Merged

feat: Cluster level default settings for Hashicorp Vault #472

merged 1 commit into from
Sep 25, 2020

Conversation

sukratkashyap
Copy link
Contributor

This PR enables global default Vault Role and Vault Mount Point setting for k8s authentication to Hashicorp Vault.

Reason:
When a user tries to deploy an app to multiple different cluster which uses the same vault. The External Secret yaml file has differences since, vaultRole and vaultMountPoint could be different for different clusters. This leads to multiple External Secret yaml file. One for each cluster. Whereas this could be specified during deployment of External Secret helm chart.

Since, a cluster will most probably will have one vaultMountPoint. It is better to have a way to deploy it at the config level. Leaving the user not to worry about role and mount point and focus on the values retrieved from the vault. Since, it is a default value. This will be backwards compatible with the previous method as it can be overwritten with the value in the External Secret manifest file.

@megakid
Copy link
Contributor

megakid commented Sep 19, 2020

Note that my new PR would be compatible with this change. #488

Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Flydiverny Flydiverny merged commit 5215090 into external-secrets:master Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants