Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

Added support for secrets versioning in Secrets Manager using version stage labels #181

Merged

Conversation

furikake
Copy link
Contributor

This commit is to add versioning support as per #175

@furikake furikake force-pushed the feature/secrets-manager-versioning branch from 1d2d65b to 6d866e0 Compare October 22, 2019 03:08
Flydiverny
Flydiverny previously approved these changes Nov 9, 2019
@Flydiverny Flydiverny dismissed their stale review November 9, 2019 02:52

perhaps we want to support both versionId & versionStage, which makes naming it version abit odd?

@furikake
Copy link
Contributor Author

I figured most people would be labeling their versions with a staging label instead of relying on a version id (UUID) since it's difficult to work with. Happy to update though.

Do you think it version should be renamed:

    - key: hello-service/credentials
      name: password
      # Version Stage in Secrets Manager
      versionStage: AWSPREVIOUS
      property: password_previous

or nested under version.versionStage

    - key: hello-service/credentials
      name: password
      # Version Stage in Secrets Manager
      version: 
        versionStage: AWSPREVIOUS
      property: password_previous

@Flydiverny
Copy link
Member

@furikake I think just renaming it to versionStage is fine :)

@Flydiverny Flydiverny merged commit 9d6c2f9 into external-secrets:master Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants