Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

Commit 8e838ee

Browse files
Cameron BoultonFlydiverny
Cameron Boulton
authored andcommitted
fix(kv-backend): Add empty keyOptions for dataFrom case. (#221)
1 parent 39fe03f commit 8e838ee

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

lib/backends/kv-backend.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class KVBackend extends AbstractBackend {
6060
*/
6161
_fetchDataFromValues ({ dataFrom, specOptions }) {
6262
return Promise.all(dataFrom.map(async key => {
63-
const value = await this._get({ key, specOptions })
63+
const value = await this._get({ key, specOptions, keyOptions: {} })
6464

6565
try {
6666
return JSON.parse(value)

lib/backends/kv-backend.test.js

+3
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ describe('kv-backend', () => {
192192

193193
expect(kvBackend._get.getCall(0).args[0]).to.deep.equal({
194194
key: 'fakePropertyKey1',
195+
keyOptions: {},
195196
specOptions: { passMeAlong: true }
196197
})
197198
expect(dataFromValues).deep.equals([undefined])
@@ -208,10 +209,12 @@ describe('kv-backend', () => {
208209

209210
expect(kvBackend._get.getCall(0).args[0]).to.deep.equal({
210211
key: 'fakePropertyKey1',
212+
keyOptions: {},
211213
specOptions: { roleArn: 'secretDescriptiorRole' }
212214
})
213215
expect(kvBackend._get.getCall(1).args[0]).to.deep.equal({
214216
key: 'fakePropertyKey2',
217+
keyOptions: {},
215218
specOptions: { roleArn: 'secretDescriptiorRole' }
216219
})
217220
expect(dataFromValues).deep.equals([{ fakePropertyName1: 'fakePropertyValue1' }, { fakePropertyName2: 'fakePropertyValue2' }])

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)