Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

Commit 6063f79

Browse files
FlydivernySilas Boyd-Wickizer
authored and
Silas Boyd-Wickizer
committed
fix: remove logging of potentially secret value (#96)
1 parent 66af903 commit 6063f79

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/backends/kv-backend.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,14 @@ class KVBackend extends AbstractBackend {
3232
try {
3333
parsedValue = JSON.parse(value)
3434
} catch (err) {
35-
this._logger.warn(`Failed to JSON.parse '${value}':`, err)
35+
this._logger.warn(`Failed to JSON.parse value for '${secretProperty.key}',` +
36+
` please verify that your secret value is correctly formatted as JSON.` +
37+
` To use plain text secret remove the 'property: ${secretProperty.property}'`)
3638
return
3739
}
3840

3941
if (!(secretProperty.property in parsedValue)) {
40-
throw new Error(`Could not find property ${secretProperty.property} in secretProperty.key`)
42+
throw new Error(`Could not find property ${secretProperty.property} in ${secretProperty.key}`)
4143
}
4244

4345
return parsedValue[secretProperty.property]

0 commit comments

Comments
 (0)