Skip to content
This repository was archived by the owner on Jul 26, 2022. It is now read-only.

Commit 45e8948

Browse files
authored
fix: remove AWS_DEFAULT_REGION (#794)
Signed-off-by: Markus Maga <[email protected]>
1 parent a7d8c6c commit 45e8948

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

charts/kubernetes-external-secrets/values.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
# Environment variables to set on deployment pod
66
env:
77
AWS_REGION: us-west-2
8-
AWS_DEFAULT_REGION: us-west-2
98
POLLER_INTERVAL_MILLISECONDS: 10000 # Caution, setting this frequency may incur additional charges on some platforms
109
WATCH_TIMEOUT: 60000
1110
WATCHED_NAMESPACES: "" # Comma separated list of namespaces, empty or unset means ALL namespaces.

e2e/README.md

-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ helm template e2e ../charts/kubernetes-external-secrets \
4242
--set env.LOCALSTACK_SM_URL=http://secretsmanager \
4343
--set env.AWS_ACCESS_KEY_ID=foobar \
4444
--set env.AWS_SECRET_ACCESS_KEY=foobar \
45-
--set env.AWS_DEFAULT_REGION=us-east-1 \
4645
--set env.AWS_REGION=us-east-1 \
4746
--set env.POLLER_INTERVAL_MILLISECONDS=1000 \
4847
--set env.LOCALSTACK_STS_URL=http://sts | kubectl apply -f -
@@ -74,7 +73,6 @@ kubectl run \
7473
--env="LOCALSTACK_SM_URL=http://secretsmanager" \
7574
--env="AWS_ACCESS_KEY_ID=foobar" \
7675
--env="AWS_SECRET_ACCESS_KEY=foobar" \
77-
--env="AWS_DEFAULT_REGION=us-east-1" \
7876
--env="AWS_REGION=us-east-1" \
7977
--env="LOCALSTACK_STS_URL=http://sts" \
8078
--overrides='{ "apiVersion": "v1", "spec":{"serviceAccountName": "external-secrets-e2e"}}' \

e2e/run-e2e-suite.sh

-2
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ helm install e2e ${CHART_DIR} \
7878
--set env.LOCALSTACK_SM_URL=http://secretsmanager \
7979
--set env.AWS_ACCESS_KEY_ID=foobar \
8080
--set env.AWS_SECRET_ACCESS_KEY=foobar \
81-
--set env.AWS_DEFAULT_REGION=us-east-1 \
8281
--set env.AWS_REGION=us-east-1 \
8382
--set env.POLLER_INTERVAL_MILLISECONDS=1000 \
8483
--set env.LOCALSTACK_STS_URL=http://sts
@@ -108,7 +107,6 @@ kubectl run \
108107
--env="LOCALSTACK_SM_URL=http://secretsmanager" \
109108
--env="AWS_ACCESS_KEY_ID=foobar" \
110109
--env="AWS_SECRET_ACCESS_KEY=foobar" \
111-
--env="AWS_DEFAULT_REGION=us-east-1" \
112110
--env="AWS_REGION=us-east-1" \
113111
--env="LOCALSTACK_STS_URL=http://sts" \
114112
--overrides='{ "apiVersion": "v1", "spec":{"serviceAccountName": "external-secrets-e2e"}}' \

0 commit comments

Comments
 (0)