fix(IBM): correctly extract secret data for IBM IAM credentials type secrets (#792)

mailtokun · Flydiverny · web-flow · commit 2f16714d13b2 · 2021-07-12T14:44:44.000+02:00
* fix bug for getting apikey of IBM IAM credentials type

* chore: fix lint issues

Co-authored-by: Markus Maga &lt;markus@maga.se&gt;
diff --git a/lib/backends/ibmcloud-secrets-manager-backend.js b/lib/backends/ibmcloud-secrets-manager-backend.js
@@ -47,7 +47,11 @@ class IbmCloudSecretsManagerBackend extends KVBackend {
       secretType: secretType,
       id: key
     })
-    return JSON.stringify(secret.result.resources[0].secret_data)
+    if (secretType === 'iam_credentials') {
+      return JSON.stringify(secret.result.resources[0].api_key)
+    } else {
+      return JSON.stringify(secret.result.resources[0].secret_data)
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,11 @@ class IbmCloudSecretsManagerBackend extends KVBackend {`
`47`	`47`	`secretType: secretType,`
`48`	`48`	`id: key`
`49`	`49`	`})`
`50`		`- return JSON.stringify(secret.result.resources[0].secret_data)`
	`50`	`+ if (secretType === 'iam_credentials') {`
	`51`	`+ return JSON.stringify(secret.result.resources[0].api_key)`
	`52`	`+ } else {`
	`53`	`+ return JSON.stringify(secret.result.resources[0].secret_data)`
	`54`	`+ }`
`51`	`55`	`}`
`52`	`56`	`}`
`53`	`57`