-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Reduce the number of links in the menu. #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm okay with this change and it gets rid of #1704 (my arch nemesis). |
Hey @bjohansebas This is just a rough example version. This is right before it breaks for mobile. Larger it could go back to single liners. it's better if we remove the Home, which we don't really need since we have the logo PS - the language picker needs some identifier like a an arrow, or at least some border. I'm making an issue for that - which can be closed if others disagree. |
Having the home link is already a convention on many websites, so it would feel strange to remove it.
I would really prefer to always have the icon instead of the text, but if we don't make that change, it definitely needs an arrow. |
It might still work with the Home if we don't want to delete that. I dont want to shrink the text as it's already quite small. What about a Home icon, like a house, with an alt tag? Or the svg w title? RE: the language picker - the issue I was seeing was a result of changing the breakpoints, that's why my imgs show english, but we still need an icon. I assume the Japanese one in prod is not what you mean, it is? The fact that it's Japanese is way better than the word English though. Eiither way, adding an arrow would essentially solve this. I feel like it needs a title on hover over the language links too. I made #1804 but closed it until I can be accurate in the problem. We can move any discussion about this issue over there. |
I don't fully understand the message regarding Home. Maybe you can create a draft PR so we can start working on it and better understand your idea. |
What do you think about reducing the number of links in the menu? That is, keeping the following links:
With this, other elements would also be adjusted to make it more compact, but it's just an initial idea.
And throughout the documentation, we could display the following menu, similar to how other pages do (with our own information, of course):
This would resolve #1704
The text was updated successfully, but these errors were encountered: