Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing semicolon in express/examples/auth/views/head.ejs #6296

Closed
pr4j3sh opened this issue Jan 25, 2025 · 2 comments
Closed

Missing semicolon in express/examples/auth/views/head.ejs #6296

pr4j3sh opened this issue Jan 25, 2025 · 2 comments
Labels

Comments

@pr4j3sh
Copy link
Contributor

pr4j3sh commented Jan 25, 2025

In express/examples/auth/views/head.ejs at line 13, CSS style for .error class' color attribute is missing a semicolon.

.error {
    color: red
}

The code does not break as the missing semicolon is at the end of the last declaration in the block.

However, for consistency and best practice, a semicolon must be included, even for the last declaration.

Fix

The process for bug fixing is:

  • We will insert a semicolon
.error {
    color: red;
}
@pr4j3sh pr4j3sh added the bug label Jan 25, 2025
@UlisesGascon
Copy link
Member

Hey @pr4j3sh! Do you want to create a PR for this? :)

@pr4j3sh
Copy link
Contributor Author

pr4j3sh commented Jan 25, 2025

I have created a PR. You may review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants