Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This makes me think: should other things, like this.cache and app.locals, use Object.create(null) too? #6185

Closed
newkdr opened this issue Nov 22, 2024 · 3 comments

Comments

@newkdr
Copy link

newkdr commented Nov 22, 2024

          This makes me think: should other things, like `this.cache` and `app.locals`, use `Object.create(null)` too?

Originally posted by @EvanHahn in #4835 (comment)

@wesleytodd
Copy link
Member

All of these would be breaking changes. This is why it was called out as going into the next major at the time. That has now shipped, so I agree we should do some of this if we keep all those APIs as is for v6, but we should wait a bit to start opening PRs for that until we decide if those are all worth doing.

@EvanHahn
Copy link
Contributor

I did this in #4861. Not sure of the status in v5, though.

@newkdr newkdr closed this as completed Nov 22, 2024
@wesleytodd
Copy link
Member

Oh right! I forgot about those. Looks like those landed before we pushed v5! Sorry, so much going on I have lost track of some of the details. Glad you remembered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants