Skip to content

Commit 7784201

Browse files
committed
refactor: Remove utils-merge dependency - use Object.assign() instead
1 parent c70197a commit 7784201

File tree

5 files changed

+6
-9
lines changed

5 files changed

+6
-9
lines changed

History.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
unreleased
22
========================
33

4+
* Remove `utils-merge` dependency - use `Object.assign()` instead
45
* Remove `Object.setPrototypeOf` polyfill
56

67
5.0.1 / 2024-10-08

lib/application.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ var http = require('http');
2121
var compileETag = require('./utils').compileETag;
2222
var compileQueryParser = require('./utils').compileQueryParser;
2323
var compileTrust = require('./utils').compileTrust;
24-
var merge = require('utils-merge');
2524
var resolve = require('path').resolve;
2625
var once = require('once')
2726
var Router = require('router');
@@ -535,15 +534,15 @@ app.render = function render(name, options, callback) {
535534
}
536535

537536
// merge app.locals
538-
merge(renderOptions, this.locals);
537+
Object.assign(renderOptions, this.locals);
539538

540539
// merge options._locals
541540
if (opts._locals) {
542-
merge(renderOptions, opts._locals);
541+
Object.assign(renderOptions, opts._locals);
543542
}
544543

545544
// merge options
546-
merge(renderOptions, opts);
545+
Object.assign(renderOptions, opts);
547546

548547
// set .cache unless explicitly provided
549548
if (renderOptions.cache == null) {

lib/response.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ var mime = require('mime-types')
2323
var path = require('path');
2424
var pathIsAbsolute = require('path').isAbsolute;
2525
var statuses = require('statuses')
26-
var merge = require('utils-merge');
2726
var sign = require('cookie-signature').sign;
2827
var normalizeType = require('./utils').normalizeType;
2928
var normalizeTypes = require('./utils').normalizeTypes;
@@ -733,7 +732,7 @@ res.clearCookie = function clearCookie(name, options) {
733732
*/
734733

735734
res.cookie = function (name, value, options) {
736-
var opts = merge({}, options);
735+
var opts = Object.assign({}, options);
737736
var secret = this.req.secret;
738737
var signed = opts.signed;
739738

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
"serve-static": "^2.1.0",
6161
"statuses": "2.0.1",
6262
"type-is": "^2.0.0",
63-
"utils-merge": "1.0.1",
6463
"vary": "~1.1.2"
6564
},
6665
"devDependencies": {

test/res.cookie.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
var express = require('../')
44
, request = require('supertest')
55
, cookieParser = require('cookie-parser')
6-
var merge = require('utils-merge');
76

87
describe('res', function(){
98
describe('.cookie(name, object)', function(){
@@ -130,7 +129,7 @@ describe('res', function(){
130129
var app = express();
131130

132131
var options = { maxAge: 1000 };
133-
var optionsCopy = merge({}, options);
132+
var optionsCopy = Object.assign({}, options);
134133

135134
app.use(function(req, res){
136135
res.cookie('name', 'tobi', options)

0 commit comments

Comments
 (0)