Remove res.jsonp(status, obj) signature

Author: tunniclm

History.md

@@ -3,6 +3,9 @@
 
 This incorporates all changes after 4.13.1 up to 4.14.0.
 
+ * remove:
+    - `res.jsonp(status, obj)` signature - use `res.status(status).jsonp(val)`
+
 5.0.0-alpha.2 / 2015-07-06
 ==========================
 

lib/response.js

@@ -234,20 +234,11 @@ res.json = function json(obj) {
  *     res.jsonp(null);
  *     res.jsonp({ user: 'tj' });
  *
- * @param {string|number|boolean|object} obj
+ * @param {string|number|boolean|object} val
  * @public
  */
 
-res.jsonp = function jsonp(obj) {
-  var val = obj;
-
-  // support res.jsonp(status, obj)
-  if (arguments.length === 2) {
-    deprecate('res.jsonp(status, obj): Use res.status(status).jsonp(obj) instead');
-    this.statusCode = arguments[0];
-    val = arguments[1];
-  }
-
+res.jsonp = function jsonp(val) {
   // settings
   var app = this.app;
   var replacer = app.get('json replacer');

test/res.jsonp.js

@@ -286,21 +286,6 @@ describe('res', function(){
     })
   })
 
-  describe('.jsonp(status, object)', function(){
-    it('should respond with json and set the .statusCode', function(done){
-      var app = express();
-
-      app.use(function(req, res){
-        res.jsonp(201, { id: 1 });
-      });
-
-      request(app)
-      .get('/')
-      .expect('Content-Type', 'application/json; charset=utf-8')
-      .expect(201, '{"id":1}', done)
-    })
-  })
-
   it('should not override previous Content-Types', function(done){
     var app = express();