Skip to content

Commit fda2450

Browse files
committed
tests: replace deprecated assert.deepEqual with deep-equal
1 parent 494ee06 commit fda2450

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"cookie-signature": "1.0.6"
1818
},
1919
"devDependencies": {
20+
"deep-equal": "1.0.1",
2021
"eslint": "4.19.1",
2122
"eslint-config-standard": "11.0.0",
2223
"eslint-plugin-import": "2.14.0",

test/cookieParser.js

+13-12
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
var assert = require('assert')
33
var cookieParser = require('..')
4+
var deepEqual = require('deep-equal')
45
var http = require('http')
56
var request = require('supertest')
67
var signature = require('cookie-signature')
@@ -158,7 +159,7 @@ describe('cookieParser.JSONCookie(str)', function () {
158159
})
159160

160161
it('should return object for JSON cookie string', function () {
161-
assert.deepEqual(cookieParser.JSONCookie('j:{"foo":"bar"}'), { foo: 'bar' })
162+
deepEqual(cookieParser.JSONCookie('j:{"foo":"bar"}'), { foo: 'bar' })
162163
})
163164

164165
it('should return undefined on invalid JSON', function () {
@@ -216,18 +217,18 @@ describe('cookieParser.signedCookie(str, secret)', function () {
216217

217218
describe('cookieParser.signedCookies(obj, secret)', function () {
218219
it('should ignore non-signed strings', function () {
219-
assert.deepEqual(cookieParser.signedCookies({}, 'keyboard cat'), {})
220-
assert.deepEqual(cookieParser.signedCookies({ foo: 'bar' }, 'keyboard cat'), {})
220+
deepEqual(cookieParser.signedCookies({}, 'keyboard cat'), {})
221+
deepEqual(cookieParser.signedCookies({ foo: 'bar' }, 'keyboard cat'), {})
221222
})
222223

223224
it('should include tampered strings as false', function () {
224-
assert.deepEqual(cookieParser.signedCookies({ foo: 's:foobaz.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
225+
deepEqual(cookieParser.signedCookies({ foo: 's:foobaz.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
225226
foo: false
226227
})
227228
})
228229

229230
it('should include unsigned strings', function () {
230-
assert.deepEqual(cookieParser.signedCookies({ foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
231+
deepEqual(cookieParser.signedCookies({ foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
231232
foo: 'foobar'
232233
})
233234
})
@@ -237,17 +238,17 @@ describe('cookieParser.signedCookies(obj, secret)', function () {
237238
foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE'
238239
}
239240

240-
assert.deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
241-
assert.deepEqual(obj, {})
241+
deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
242+
deepEqual(obj, {})
242243
})
243244

244245
it('should remove tampered strings from original object', function () {
245246
var obj = {
246247
foo: 's:foobaz.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE'
247248
}
248249

249-
assert.deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: false })
250-
assert.deepEqual(obj, {})
250+
deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: false })
251+
deepEqual(obj, {})
251252
})
252253

253254
it('should leave unsigned string in original object', function () {
@@ -256,8 +257,8 @@ describe('cookieParser.signedCookies(obj, secret)', function () {
256257
foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE'
257258
}
258259

259-
assert.deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
260-
assert.deepEqual(obj, { fizz: 'buzz' })
260+
deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
261+
deepEqual(obj, { fizz: 'buzz' })
261262
})
262263

263264
describe('when secret is an array', function () {
@@ -267,7 +268,7 @@ describe('cookieParser.signedCookies(obj, secret)', function () {
267268
fizz: 's:foobar.JTCAgiMWsnuZpN3mrYnEUjXlGxmDi4POCBnWbRxse88'
268269
}
269270

270-
assert.deepEqual(cookieParser.signedCookies(obj, [ 'keyboard cat', 'nyan cat' ]), {
271+
deepEqual(cookieParser.signedCookies(obj, [ 'keyboard cat', 'nyan cat' ]), {
271272
buzz: 'foobar',
272273
fizz: 'foobar'
273274
})

0 commit comments

Comments
 (0)