Skip to content

Vectors concept #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 3, 2025
Merged

Vectors concept #802

merged 8 commits into from
Mar 3, 2025

Conversation

colinleach
Copy link
Contributor

An earlier draft of this was growing out of control, so I cut it down to (mostly) just what is needed for Elyse's Enchantments.

On which subject: that draft exercise will need changing. Test 2 currently uses pairs, a concept well beyond this stage of the syllabus.

@colinleach colinleach changed the title WIP draft of arrays concept WIP draft of vectors concept Feb 28, 2025
@colinleach
Copy link
Contributor Author

colinleach commented Feb 28, 2025

Change of plan. Revisiting this a few months after I wrote it, I decided the name should reflect the content, which is mostly just Vectors. I changed the about.md and moved the directory from concepts.wip/arrays to concepts/vectors. This broke the config.json, which I'll fix in the next day or two. Meanwhile, I'm working on elyses-enchantments and will copy the introduction.md from that to this Concept.

This frees the name arrays for a later Concept on the multidimensional case.

@colinleach colinleach changed the title WIP draft of vectors concept Vectors concept Mar 1, 2025
@colinleach colinleach requested a review from depial March 1, 2025 16:06
@colinleach
Copy link
Contributor Author

I think this is about ready to review. It's probably easier to merge this before elyses-enchantments, which I'll add soon.

@colinleach colinleach marked this pull request as ready for review March 3, 2025 14:40
Copy link
Contributor

@depial depial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a potential typo in question

@colinleach colinleach merged commit f2058d8 into exercism:main Mar 3, 2025
1 check passed
@depial
Copy link
Contributor

depial commented Mar 4, 2025

On the website, I can't unlock Vectors in the syllabus after having finished everything above, and when I look at the Vector concept on the website it says there are 0 Exercises (although Elyses Enchantments is listed as completed along side), see below:

image

My best guess is that there may be an issue with the config.json being incomplete here, but I'm not sure. @colinleach have you seen this before?

@colinleach
Copy link
Contributor Author

That is very weird! If I hover my mouse over it on the Concept tree, it shows 1 exercise (same as all the other concepts). It's only after opening the Concept page that, like you, I see 0 exercises.

I can't see anything wrong with the config.json - though after all my blundering around in there over the past few days, I seem to have lost all ability to look at JSON. This is a new version of an old exercise, so I worry that something has got tangled in the website.

I'll have another think about this tomorrow. We may then need to escalate this to people who understand the inner workings of the website (pretty much only Jeremy, unfortunately).

@depial
Copy link
Contributor

depial commented Mar 5, 2025

I realized that I was thinking about julia/config.json which has more information. I agree with you that .meta/config.json doesn't seem to have anything wrong with it.

The other weird thing is that Vectors doesn't appear unlocked after finishing Conditionals, but I can still access it and do the exercise. When I hover over Vectors in the syllabus, it says "Learn to unlock this concept" where it should say "Learn conditionals to unlock this concept". Maybe a problem lies there as well?

Looking at Chessboard, I see:

image

I'll also try to think about this more tomorrow, but I'm afraid I know less about the inner working than you do.

@colinleach
Copy link
Contributor Author

I looked at both JSON files, without finding a problem. This is currently looking like something well above our pay grade! (Ironic, for unpaid volunteers).

@colinleach colinleach deleted the arrays-draft branch March 6, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants