Skip to content

Upgrade julia version #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024
Merged

Upgrade julia version #733

merged 1 commit into from
May 3, 2024

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented May 1, 2024

I'm testing if this fixes the macOS build.

@ErikSchierboom ErikSchierboom changed the title upgrade julia version Upgrade julia version May 1, 2024
@ErikSchierboom ErikSchierboom force-pushed the upgrade-julia-version branch from d39a3d4 to 6c956c0 Compare May 1, 2024 07:16
@ErikSchierboom
Copy link
Member Author

@cmcaine Upgrading to test with Julia 1.10 fixes the macOS issue where CI would fail for macos. Is there any particular reason we shouldn't do this?

@cmcaine
Copy link
Contributor

cmcaine commented May 2, 2024

We test Julia 1.6 because that is the most recent long-term support release. Testing Julia 1.10 should be redundant with testing Julia 1 (which I expect to redirect to the latest stable version of Julia 1, currently 1.10.3).

I think that if it is easy to do then we should test on only Julia 1 and nightly on MacOS. If that's not convenient, then we can test only 1 and nightly on all operating systems.

@cmcaine
Copy link
Contributor

cmcaine commented May 2, 2024

The setup-julia action is probably failing for Julia 1.6 on macOS because Julia 1.6 doesn't support ARM versions of macOS.

The x86_64 binary did work through rosetta, iirc, but maybe an update to the setup-julia action or some other infra has made it not give an x86_64 binary to newer macOS versions.

@ErikSchierboom
Copy link
Member Author

I think that if it is easy to do then we should test on only Julia 1 and nightly on MacOS. If that's not convenient, then we can test only 1 and nightly on all operating systems.

I think this is easy enough to do. I'll look into it! Thanks for explaining.

@ErikSchierboom ErikSchierboom force-pushed the upgrade-julia-version branch 3 times, most recently from 76548c2 to e19279c Compare May 3, 2024 07:44
@ErikSchierboom ErikSchierboom marked this pull request as ready for review May 3, 2024 07:56
@ErikSchierboom ErikSchierboom requested a review from a team as a code owner May 3, 2024 07:56
@ErikSchierboom ErikSchierboom merged commit 60ceb9f into main May 3, 2024
10 checks passed
@ErikSchierboom ErikSchierboom deleted the upgrade-julia-version branch May 3, 2024 07:56
@cmcaine
Copy link
Contributor

cmcaine commented May 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants