Skip to content

Remove dependence on jquery #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks
choldgraf opened this issue Jun 27, 2022 · 0 comments · Fixed by #668
Closed
4 tasks

Remove dependence on jquery #580

choldgraf opened this issue Jun 27, 2022 · 0 comments · Fixed by #668
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Member

choldgraf commented Jun 27, 2022

Context

Sphinx 6.0 is going to remove the jquery dependency by default. We use jquery a little bit in this theme, though likely not in a way that strictly requires jquery.

Here's a GitHub CS search for the $( symbol

Note that our parent theme removed JQuery as a dependency here:

Proposal

We should remove all of our code that depends on JQuery, and only manually add the JQuery dependency if we really need it.

Tasks and updates

  • Remove instances of $( in the theme as well as JQuery notes anywhere
  • Remove tooltip functionality and popper.js
  • Remove the styling of div.tooltip since we no longer use Bootstrap for this
  • Double-check functionality is the same
@choldgraf choldgraf added the enhancement New feature or request label Jun 27, 2022
@executablebooks executablebooks deleted a comment from welcome bot Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant