🚑 Fix serialization of null & undefined (#43)

Author: exah

src/index.ts

@@ -145,26 +145,25 @@ const DEFAULTS: RequiredOptions<Payload> = {
   onJSON: (json) => json,
 }
 
-function defaultSerialize(input: SearchParams): URLSearchParams {
+function serialize(input: SearchParams): URLSearchParams {
   const params = new URLSearchParams()
 
-  for (const key of Object.keys(input)) {
-    if (Array.isArray(input[key])) {
-      // @ts-expect-error checked the variable inside if statement
-      input[key].forEach((item) => params.append(key, item))
-    } else {
+  for (const [key, value] of Object.entries(input)) {
+    if (Array.isArray(value)) {
+      value.forEach((item) => params.append(key, item))
+    } else if (value != null) {
       params.append(key, input[key])
     }
   }
 
   return params
 }
 
-function mergeMaps<Init, Request extends URLSearchParams | Headers>(
+const mergeMaps = <Init, Request extends URLSearchParams | Headers>(
   M: new (init?: Init) => Request,
   left?: Init,
   right?: Init
-): Request {
+): Request => {
   const result = new M(left)
 
   new M(right).forEach((value, key) => result.append(key, value))
@@ -173,12 +172,12 @@ function mergeMaps<Init, Request extends URLSearchParams | Headers>(
 }
 
 const normalizeParams = (
-  serialize: Serialize = defaultSerialize,
+  transform: Serialize = serialize,
   params: SearchParams | URLSearchParams | string = ''
 ) =>
   typeof params === 'string' || params instanceof URLSearchParams
     ? params
-    : serialize(params)
+    : transform(params)
 
 const mergeOptions = <A extends Options<Payload>, B extends Options<Payload>>(
   left: A,
@@ -255,9 +254,11 @@ function request<P extends Payload>(
     .then(options.onResponse)
     .then(options.onSuccess, options.onFailure) as ResponsePromise<P>
 
-  for (const key of Object.keys(CONTENT_TYPES) as Array<keyof BodyMethods>) {
+  for (const [key, value] of Object.entries(CONTENT_TYPES) as Array<
+    [keyof BodyMethods, string]
+  >) {
     promise[key] = () => {
-      options.headers.set('accept', CONTENT_TYPES[key])
+      options.headers.set('accept', value)
       return promise
         .then((result) => (key === 'void' ? undefined : result.clone()[key]()))
         .then((parsed) => (key === 'json' ? options.onJSON(parsed) : parsed))
@@ -309,7 +310,7 @@ export {
   ResponseError,
   TimeoutError,
   Serialize,
-  defaultSerialize as serialize,
+  serialize,
   request,
   create,
   get,

tests/core.test.ts

@@ -298,7 +298,6 @@ describe('Response', () => {
 
     const result = await YF.get('http://localhost/blob').arrayBuffer()
 
-    // @ts-ignore
     expect(String.fromCharCode(...new Uint8Array(result))).toBe('test')
     expect(result.byteLength).toBe(4)
     expect(result).toBeInstanceOf(ArrayBuffer)
@@ -797,6 +796,8 @@ test('default serialize', () => {
     number: 0,
     string: 'text',
     array: [1, 'two', 3],
+    null: null,
+    undefined,
   }).toString()
 
   expect(result).toBe('number=0&string=text&array=1&array=two&array=3')