Add 'document' as content type in case if it's defaulted due to plugin error

elcreator · web-flow · commit bda3ee81d68c · 2023-09-26T16:56:12.000+02:00
is_scalar is not enough validation as it not checks for empty value
diff --git a/manager/actions/mutate_content.dynamic.php b/manager/actions/mutate_content.dynamic.php
@@ -136,7 +136,7 @@
     }
 }
 
-$content['type'] = get_by_key($content, 'type', $defaultContentType, 'is_scalar');
+$content['type'] = get_by_key($content, 'type', $defaultContentType, 'is_scalar') ?: $defaultContentType;
 
 if(isset ($_POST['which_editor'])) {
     $modx->setConfig('which_editor', get_by_key($_POST, 'which_editor', '', 'is_scalar'));

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`139`		`-$content['type'] = get_by_key($content, 'type', $defaultContentType, 'is_scalar');`
	`139`	`+$content['type'] = get_by_key($content, 'type', $defaultContentType, 'is_scalar') ?: $defaultContentType;`
`140`	`140`
`141`	`141`	`if(isset ($_POST['which_editor'])) {`
`142`	`142`	`$modx->setConfig('which_editor', get_by_key($_POST, 'which_editor', '', 'is_scalar'));`