Skip to content

Commit 1a2b32d

Browse files
committed
Fix dataset yaml not properly reflecting dataset in dropdown (#3666)
1 parent 89f5773 commit 1a2b32d

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ The types of changes are:
7070
- Fix bug where editing a data use on a system could delete existing data uses [#3627](https://github.com/ethyca/fides/pull/3627)
7171
- Restrict Privacy Center debug logging to development-only [#3638](https://github.com/ethyca/fides/pull/3638)
7272
- Fix bug where linking an integration would not update the tab when creating a new system [#3662](https://github.com/ethyca/fides/pull/3662)
73+
- Fix dataset yaml not properly reflecting the dataset in the dropdown of system integrations tab [#3666](https://github.com/ethyca/fides/pull/3666)
7374

7475
### Changed
7576

clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,10 @@ const ConnectorParametersForm: React.FC<ConnectorParametersFormProps> = ({
382382
: null}
383383
{SystemType.DATABASE === connectionOption.type &&
384384
!isCreatingConnectionConfig ? (
385-
<DatasetConfigField dropdownOptions={datasetDropdownOptions} />
385+
<DatasetConfigField
386+
dropdownOptions={datasetDropdownOptions}
387+
connectionConfig={connectionConfig}
388+
/>
386389
) : null}
387390
<ButtonGroup size="sm" spacing="8px" variant="outline">
388391
<Button

clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/fields/DatasetConfigField/DatasetConfigField.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export const DatasetSelect = ({
6666
isInvalid={isInvalid}
6767
isRequired={isRequired}
6868
>
69-
{/* <VStack align="flex-start" w="inherit"> */}
7069
{label ? (
7170
<Label htmlFor={props.id || props.name} {...labelProps}>
7271
{label}
@@ -107,7 +106,6 @@ export const DatasetSelect = ({
107106
/>
108107
{tooltip ? <QuestionTooltip label={tooltip} /> : null}
109108
</Flex>
110-
{/* </VStack> */}
111109
</FormControl>
112110
);
113111
};

0 commit comments

Comments
 (0)