Skip to content

Commit a94caf0

Browse files
authored
fix: correctly apply extra params if builder is enabled (#725)
I noticed it is not possible to run mixed vc<>bn clients if builder / mev is enabled as it applies extra flags from other clients in `vc_extra_params` as the params are applied based on `cl_type` but it should be done based on `vc_type`. I tested this using the [following config](https://gist.github.com/nflaig/949c8b5101127961023d89de9c206b04) with both `mev_type: mock` and `mev_type: flashbots`.
1 parent 7dc6660 commit a94caf0

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

src/package_io/input_parser.star

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1054,33 +1054,38 @@ def enrich_mev_extra_params(parsed_arguments_dict, mev_prefix, mev_port, mev_typ
10541054
)
10551055

10561056
if participant["cl_type"] == "lighthouse":
1057-
participant["vc_extra_params"].append("--builder-proposals")
10581057
participant["cl_extra_params"].append("--builder={0}".format(mev_url))
1058+
if participant["vc_type"] == "lighthouse":
1059+
participant["vc_extra_params"].append("--builder-proposals")
10591060
if participant["cl_type"] == "lodestar":
1060-
participant["vc_extra_params"].append("--builder")
10611061
participant["cl_extra_params"].append("--builder")
10621062
participant["cl_extra_params"].append("--builder.urls={0}".format(mev_url))
1063+
if participant["vc_type"] == "lodestar":
1064+
participant["vc_extra_params"].append("--builder")
10631065
if participant["cl_type"] == "nimbus":
1064-
participant["vc_extra_params"].append("--payload-builder=true")
10651066
participant["cl_extra_params"].append("--payload-builder=true")
10661067
participant["cl_extra_params"].append(
10671068
"--payload-builder-url={0}".format(mev_url)
10681069
)
1070+
if participant["vc_type"] == "nimbus":
1071+
participant["vc_extra_params"].append("--payload-builder=true")
10691072
if participant["cl_type"] == "teku":
1070-
participant["vc_extra_params"].append(
1071-
"--validators-builder-registration-default-enabled=true"
1072-
)
10731073
participant["cl_extra_params"].append(
10741074
"--builder-endpoint={0}".format(mev_url)
10751075
)
10761076
participant["cl_extra_params"].append(
10771077
"--validators-builder-registration-default-enabled=true"
10781078
)
1079+
if participant["vc_type"] == "teku":
1080+
participant["vc_extra_params"].append(
1081+
"--validators-builder-registration-default-enabled=true"
1082+
)
10791083
if participant["cl_type"] == "prysm":
1080-
participant["vc_extra_params"].append("--enable-builder")
10811084
participant["cl_extra_params"].append(
10821085
"--http-mev-relay={0}".format(mev_url)
10831086
)
1087+
if participant["vc_type"] == "prysm":
1088+
participant["vc_extra_params"].append("--enable-builder")
10841089
if participant["cl_type"] == "grandine":
10851090
participant["cl_extra_params"].append("--builder-url={0}".format(mev_url))
10861091

0 commit comments

Comments
 (0)