Use filepath.clean instead of path.clean (#26404)

* internal/flags: use filepath.Clean instead of path.Clean

* internal/flags: fix windows pipe issue

* internal/flags: modify test for windows

* internal/flags: use backticks, fix test

Author: MariusVanDerWijden

internal/flags/flags.go

@@ -23,7 +23,7 @@ import (
 	"math/big"
 	"os"
 	"os/user"
-	"path"
+	"path/filepath"
 	"strings"
 
 	"github.com/ethereum/go-ethereum/common/math"
@@ -314,12 +314,16 @@ func GlobalBig(ctx *cli.Context, name string) *big.Int {
 // 3. cleans the path, e.g. /a/b/../c -> /a/c
 // Note, it has limitations, e.g. ~someuser/tmp will not be expanded
 func expandPath(p string) string {
+	// Named pipes are not file paths on windows, ignore
+	if strings.HasPrefix(p, `\\.\pipe`) {
+		return p
+	}
 	if strings.HasPrefix(p, "~/") || strings.HasPrefix(p, "~\\") {
 		if home := HomeDir(); home != "" {
 			p = home + p[1:]
 		}
 	}
-	return path.Clean(os.ExpandEnv(p))
+	return filepath.Clean(os.ExpandEnv(p))
 }
 
 func HomeDir() string {

internal/flags/flags_test.go

@@ -19,23 +19,43 @@ package flags
 import (
 	"os"
 	"os/user"
+	"runtime"
 	"testing"
 )
 
 func TestPathExpansion(t *testing.T) {
 	user, _ := user.Current()
-	tests := map[string]string{
-		"/home/someuser/tmp": "/home/someuser/tmp",
-		"~/tmp":              user.HomeDir + "/tmp",
-		"~thisOtherUser/b/":  "~thisOtherUser/b",
-		"$DDDXXX/a/b":        "/tmp/a/b",
-		"/a/b/":              "/a/b",
+	var tests map[string]string
+
+	if runtime.GOOS == "windows" {
+		tests = map[string]string{
+			`/home/someuser/tmp`:        `\home\someuser\tmp`,
+			`~/tmp`:                     user.HomeDir + `\tmp`,
+			`~thisOtherUser/b/`:         `~thisOtherUser\b`,
+			`$DDDXXX/a/b`:               `\tmp\a\b`,
+			`/a/b/`:                     `\a\b`,
+			`C:\Documents\Newsletters\`: `C:\Documents\Newsletters`,
+			`C:\`:                       `C:\`,
+			`\\.\pipe\\pipe\geth621383`: `\\.\pipe\\pipe\geth621383`,
+		}
+	} else {
+		tests = map[string]string{
+			`/home/someuser/tmp`:        `/home/someuser/tmp`,
+			`~/tmp`:                     user.HomeDir + `/tmp`,
+			`~thisOtherUser/b/`:         `~thisOtherUser/b`,
+			`$DDDXXX/a/b`:               `/tmp/a/b`,
+			`/a/b/`:                     `/a/b`,
+			`C:\Documents\Newsletters\`: `C:\Documents\Newsletters\`,
+			`C:\`:                       `C:\`,
+			`\\.\pipe\\pipe\geth621383`: `\\.\pipe\\pipe\geth621383`,
+		}
 	}
-	os.Setenv("DDDXXX", "/tmp")
+
+	os.Setenv(`DDDXXX`, `/tmp`)
 	for test, expected := range tests {
 		got := expandPath(test)
 		if got != expected {
-			t.Errorf("test %s, got %s, expected %s\n", test, got, expected)
+			t.Errorf(`test %s, got %s, expected %s\n`, test, got, expected)
 		}
 	}
 }